Provide a helper to generate multiple Lithium instructions for one Hydrogen instruction.

Provide a helper to generate multiple Lithium instructions for one Hydrogen instruction.

R=jkummerow@chromium.org, ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21465

[Alexandre Rames, 2014-05-22 12:54:39]

This is a pre-requisite commit for issue 296113008.

[Jakob Kummerow, 2014-05-22 12:59:45]

LGTM with comment.

I've only looked at arm, I assume other platforms are identical.

https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc#newco...
src/arm/lithium-arm.cc:843: void
LChunkBuilder::CheckAndAddInstruction(LInstruction* instr,
I'd call this just AddInstruction...

https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc#newco...
src/arm/lithium-arm.cc:845: if (instr != NULL) {
...and move this check to the caller. I don't think other callers need the
flexibility to pass in NULL.

[Alexandre Rames, 2014-05-22 13:15:43]

Yes, all platforms have the same changes.

https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc#newco...
src/arm/lithium-arm.cc:843: void
LChunkBuilder::CheckAndAddInstruction(LInstruction* instr,
On 2014/05/22 12:59:46, Jakob wrote:
> I'd call this just AddInstruction...

Done.

https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc#newco...
src/arm/lithium-arm.cc:845: if (instr != NULL) {
On 2014/05/22 12:59:46, Jakob wrote:
> ...and move this check to the caller. I don't think other callers need the
> flexibility to pass in NULL.

Done.

[ulan, 2014-05-22 14:52:44]

lgtm

[Jakob Kummerow, 2014-05-22 14:56:20]

Please don't forget to upload the updated patch set for future reference.

[Alexandre Rames, 2014-05-22 15:15:32]

On 2014/05/22 14:56:20, Jakob wrote:
> Please don't forget to upload the updated patch set for future reference.

Just did. I was waiting for our internal green flag.

[Alexandre Rames, 2014-05-23 13:15:21]

Committed patchset #2 manually as r21465 (presubmit successful).