[vr] Hide 2D UI when entering VR for WebVR auto-presentation

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 312 matching lines @@
 
         mFullscreenManager = createFullscreenManager();
         mCreatedFullscreenManager = true;
     }
 
     @SuppressLint("NewApi")
     @Override
     public void postInflationStartup() {
         super.postInflationStartup();
 
+        Intent intent = getIntent();
+        if (intent != null && getSavedInstanceState() == null) {
+            VrShellDelegate.maybeHandleVrIntentPreNative(this, intent);
+        }
+
         mSnackbarManager = new SnackbarManager(this, null);
         mDataUseSnackbarController = new DataUseSnackbarController(this, getSnackbarManager());
 
         mAssistStatusHandler = createAssistStatusHandler();
         if (mAssistStatusHandler != null) {
             if (mTabModelSelector != null) {
                 mAssistStatusHandler.setTabModelSelector(mTabModelSelector);
             }
             mAssistStatusHandler.updateAssistState();
         }
@@ skipping 564 matching lines @@
                 if (syncService != null) {
                     syncService.removeSyncStateChangedListener(mSyncStateChangedListener);
                 }
                 mSyncStateChangedListener = null;
             }
         }
         super.onStopWithNative();
     }
 
     @Override
+    protected void onNewIntent(Intent intent) {
+        super.onNewIntent(intent);
+        VrShellDelegate.maybeHandleVrIntentPreNative(this, intent);
+    }
+
+    @Override
     public void onNewIntentWithNative(Intent intent) {
         mPictureInPictureController.cleanup(this);
 
         super.onNewIntentWithNative(intent);
         if (mIntentHandler.shouldIgnoreIntent(intent)) return;
 
+        // We send this intent so that we can enter WebVr presentation mode if needed. This
+        // call doesn't consume the intent because it also has the url that we need to load.
+        VrShellDelegate.onNewIntentWithNative(this, intent);
         mIntentHandler.onNewIntent(intent);
     }
 
     /**
      * @return Whether the given activity contains a CustomTab.
      */
     public boolean isCustomTab() {
         return false;
     }
 
@@ skipping 275 matching lines @@
         mRemoveWindowBackgroundDone = true;
     }
 
     @Override
     public void finishNativeInitialization() {
         mNativeInitialized = true;
         OfflineContentAggregatorNotificationBridgeUiFactory.instance();
         maybeRemoveWindowBackground();
         DownloadManagerService.getDownloadManagerService().onActivityLaunched();
 
-        VrShellDelegate.onNativeLibraryAvailable();
+        Intent intent = getSavedInstanceState() == null ? getIntent() : null;
+        VrShellDelegate.onNativeLibraryAvailable(this, intent);

[Ted C, 2017/07/14 00:12:05]

I'd recommend not passing the intent in this call, but to keep it more
predictable on the vr side to do:

VrShellDelegate.onNativeLibraryAvailable(this);
if (getSavedInstanceState() == null && getIntent() != null) {
    VrShellDelegate.onNewIntentWithNative(this, getIntent());
}

I think having an api do the same as another just leads to more headache IMO.

[ymalik, 2017/07/14 05:27:43]

Thanks, Done.

         super.finishNativeInitialization();
     }
 
     /**
      * Called when the accessibility status of this device changes.  This might be triggered by
      * touch exploration or general accessibility status updates.  It is an aggregate of two other
      * accessibility update methods.
      * @see #onAccessibilityModeChanged(boolean)
      * @see #onTouchExplorationStateChanged(boolean)
      * @param enabled Whether or not accessibility and touch exploration are currently enabled.
@@ skipping 1005 matching lines @@
         return false;
     }
 
     /**
      * @return the reference pool for this activity.
      */
     public DiscardableReferencePool getReferencePool() {
         return mReferencePool;
     }
 }