Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: pkg/compiler/lib/src/js/rewrite_async.dart

Issue 2969873002: Add NodeVisitor1 to js_ast (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js/rewrite_async.dart
diff --git a/pkg/compiler/lib/src/js/rewrite_async.dart b/pkg/compiler/lib/src/js/rewrite_async.dart
index 179a37f4b1d14f444cd169843879d83399b6475e..69bea4522629f87ff1d85224de11725905f2b17a 100644
--- a/pkg/compiler/lib/src/js/rewrite_async.dart
+++ b/pkg/compiler/lib/src/js/rewrite_async.dart
@@ -363,14 +363,16 @@ abstract class AsyncRewriterBase extends js.NodeVisitor {
/// If the return value of visiting [node] is an expression guaranteed to have
/// no side effect, it is dropped.
void visitExpressionIgnoreResult(js.Expression node) {
- js.Expression result = node.accept(this);
+ // TODO(28763): Remove `<dynamic>` which issue 28763 is fixed.
+ js.Expression result = node.accept<dynamic>(this);
if (!(result is js.Literal || result is js.VariableUse)) {
addExpressionStatement(result);
}
}
js.Expression visitExpression(js.Expression node) {
- return node.accept(this);
+ // TODO(28763): Remove `<dynamic>` which issue 28763 is fixed.
+ return node.accept<dynamic>(this);
}
/// Calls [fn] with the value of evaluating [node1] and [node2].

Powered by Google App Engine
This is Rietveld 408576698