Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2969873002: Add NodeVisitor1 to js_ast (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+768 lines, -119 lines) Patch
M pkg/compiler/lib/src/js/js.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/js_ast/lib/src/nodes.dart View 60 chunks +762 lines, -116 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-03 11:51:46 UTC) #2
sra1
lgtm https://codereview.chromium.org/2969873002/diff/1/pkg/compiler/lib/src/js/js.dart File pkg/compiler/lib/src/js/js.dart (right): https://codereview.chromium.org/2969873002/diff/1/pkg/compiler/lib/src/js/js.dart#newcode119 pkg/compiler/lib/src/js/js.dart:119: // TODO(28763): Remove `<dynamic>` which issue 28763 is ...
3 years, 5 months ago (2017-07-05 20:52:13 UTC) #3
Johnni Winther
https://codereview.chromium.org/2969873002/diff/1/pkg/compiler/lib/src/js/js.dart File pkg/compiler/lib/src/js/js.dart (right): https://codereview.chromium.org/2969873002/diff/1/pkg/compiler/lib/src/js/js.dart#newcode119 pkg/compiler/lib/src/js/js.dart:119: // TODO(28763): Remove `<dynamic>` which issue 28763 is fixed. ...
3 years, 5 months ago (2017-07-06 07:41:36 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-07-06 08:25:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
436eefbb337491f8a9f66a2b0186923ad6fb73d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698