Issue 296983003: MIPS: Allow specifying base offset when constructing Keyed hydrogen instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296983003: MIPS: Allow specifying base offset when constructing Keyed hydrogen instructions. (Closed)

Created:
6 years, 7 months ago by kilvadyb

Modified:
6 years, 7 months ago

Reviewers:
kisg, Paul Lind, palfia, danno, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Allow specifying base offset when constructing Keyed hydrogen instructions. Port r21426 (17e6338) This is preparation for pending hydrogen stub work that needs to access memory using KeyedLoad/KeyedStore operations where the base offset used for the accesses are is the the default (e.g. the size of an FixedArray header for FixedArrays or zero for external arrays). BUG=

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -72 lines)			Patch
M	src/mips/lithium-codegen-mips.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	14 chunks	+27 lines, -66 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Committed as r21443.

Expand Messages | Collapse Messages