Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2969793002: Clean up AstProvider hierarchy (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -55 lines) Patch
D pkg/analyzer/lib/src/dart/analysis/ast_provider_context.dart View 1 chunk +0 lines, -31 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/ast_provider_driver.dart View 3 chunks +22 lines, -24 lines 2 comments Download
M pkg/analyzer/lib/src/dart/element/ast_provider.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-07-01 16:03:07 UTC) #2
scheglov
https://codereview.chromium.org/2969793002/diff/1/pkg/analyzer/lib/src/dart/analysis/ast_provider_driver.dart File pkg/analyzer/lib/src/dart/analysis/ast_provider_driver.dart (right): https://codereview.chromium.org/2969793002/diff/1/pkg/analyzer/lib/src/dart/analysis/ast_provider_driver.dart#newcode16 pkg/analyzer/lib/src/dart/analysis/ast_provider_driver.dart:16: class AstProviderForDriver implements AstProvider { I think we might ...
3 years, 5 months ago (2017-07-01 16:14:15 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as f6a2fb0050eeaf24706da66bdd73c2f3c9770f96 (presubmit successful).
3 years, 5 months ago (2017-07-01 19:06:43 UTC) #5
Brian Wilkerson
3 years, 5 months ago (2017-07-02 04:45:09 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2969793002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/ast_provider_driver.dart (right):

https://codereview.chromium.org/2969793002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/ast_provider_driver.dart:16: class
AstProviderForDriver implements AstProvider {
I thought about that, but I'm not sure that we won't need it for Angular
support.

Powered by Google App Engine
This is Rietveld 408576698