Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1388)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2969753002: [DevTools] Split auto-attach part of TargetHandler into a separate class (Closed)
Patch Set: rebased, addressed comment Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/protocol/target_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index d7e33429fe48e58bac3c108c8fbe2ffa5556a54c..6dae7615be4eabddd00f2fce16e9bbd875ede214 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -647,7 +647,7 @@ void RenderFrameDevToolsAgentHost::DidFinishNavigation(
CommitPending();
}
for (auto* target : protocol::TargetHandler::ForAgentHost(this))
- target->UpdateServiceWorkers();
+ target->DidCommitNavigation();
} else if (pending_ && pending_->host()->GetFrameTreeNodeId() ==
navigation_handle->GetFrameTreeNodeId()) {
DiscardPending();
@@ -685,7 +685,7 @@ void RenderFrameDevToolsAgentHost::DidFinishNavigation(
}
if (handle->HasCommitted()) {
for (auto* target : protocol::TargetHandler::ForAgentHost(this))
- target->UpdateServiceWorkers();
+ target->DidCommitNavigation();
}
}
@@ -819,7 +819,7 @@ void RenderFrameDevToolsAgentHost::RenderFrameHostChanged(
RenderFrameHost* old_host,
RenderFrameHost* new_host) {
for (auto* target : protocol::TargetHandler::ForAgentHost(this))
- target->UpdateFrames();
+ target->RenderFrameHostChanged();
if (IsBrowserSideNavigationEnabled()) {
if (old_host != frame_host_)
« no previous file with comments | « content/browser/devtools/protocol/target_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698