Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2969723002: [VM, generic functions reification, work in progress] (Closed)

Created:
3 years, 5 months ago by regis
Modified:
3 years, 5 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[VM, generic functions reification, work in progress] Support passing type arguments in a generic instance call. Note that kernel is always used for compiling InvokeFieldDispatcher functions. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/9a65805689a249ef5fe8c913ce04a8b3f3ff8163

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into slave #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M runtime/vm/kernel_binary_flowgraph.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
regis
3 years, 5 months ago (2017-06-30 17:41:46 UTC) #2
zra
lgtm but would you mind updating the CL description with a little more context? Thanks!
3 years, 5 months ago (2017-06-30 19:09:02 UTC) #3
regis
On 2017/06/30 19:09:02, zra wrote: > lgtm but would you mind updating the CL description ...
3 years, 5 months ago (2017-06-30 20:17:48 UTC) #5
regis
3 years, 5 months ago (2017-06-30 20:18:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9a65805689a249ef5fe8c913ce04a8b3f3ff8163 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698