Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: components/sync/test/fake_server/bookmark_entity_builder.h

Issue 2969643002: Reland - Replace FakeServer's implementation with LoopbackServer invocations. (Closed)
Patch Set: Rebased on master. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/test/fake_server/bookmark_entity_builder.h
diff --git a/components/sync/test/fake_server/bookmark_entity_builder.h b/components/sync/test/fake_server/bookmark_entity_builder.h
index b1c15861d723ba1145010a971efcd8e0c2664b56..10cb7844ceb409967e7028e53310ad59b7899c9b 100644
--- a/components/sync/test/fake_server/bookmark_entity_builder.h
+++ b/components/sync/test/fake_server/bookmark_entity_builder.h
@@ -9,7 +9,7 @@
#include <string>
#include "components/sync/base/model_type.h"
-#include "components/sync/test/fake_server/fake_server_entity.h"
+#include "components/sync/engine_impl/loopback_server/loopback_server_entity.h"
#include "url/gurl.h"
namespace fake_server {
@@ -29,22 +29,22 @@ class BookmarkEntityBuilder {
// the bookmark will be included in the bookmarks bar.
void SetParentId(const std::string& parent_id);
- // Builds and returns a FakeServerEntity representing a bookmark. Returns null
- // if the entity could not be built.
- std::unique_ptr<FakeServerEntity> BuildBookmark(const GURL& url);
+ // Builds and returns a LoopbackServerEntity representing a bookmark. Returns
+ // null if the entity could not be built.
+ std::unique_ptr<syncer::LoopbackServerEntity> BuildBookmark(const GURL& url);
- // Builds and returns a FakeServerEntity representing a bookmark folder.
+ // Builds and returns a LoopbackServerEntity representing a bookmark folder.
// Returns null if the entity could not be built.
- std::unique_ptr<FakeServerEntity> BuildFolder();
+ std::unique_ptr<syncer::LoopbackServerEntity> BuildFolder();
private:
// Creates an EntitySpecifics and pre-populates its BookmarkSpecifics with
// the entity's title.
sync_pb::EntitySpecifics CreateBaseEntitySpecifics() const;
- // Builds the parts of a FakeServerEntity common to both normal bookmarks and
- // folders.
- std::unique_ptr<FakeServerEntity> Build(
+ // Builds the parts of a LoopbackServerEntity common to both normal bookmarks
+ // and folders.
+ std::unique_ptr<syncer::LoopbackServerEntity> Build(
const sync_pb::EntitySpecifics& entity_specifics,
bool is_folder);
« no previous file with comments | « components/sync/test/fake_server/bookmark_entity.cc ('k') | components/sync/test/fake_server/bookmark_entity_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698