components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc - Issue 2969643002: Reland - Replace FakeServer's implementation with LoopbackServer invocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc

Issue 2969643002: Reland - Replace FakeServer's implementation with LoopbackServer invocations. (Closed)

Patch Set: Rebased on master. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/engine_impl/loopback_server/persistent_permanent_entity.h ('k') | components/sync/engine_impl/loopback_server/persistent_tombstone_entity.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc

diff --git a/components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc b/components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc

index e85aa022b8eb486c88599356bebdf918d98daa83..48d25cfe3c012f3372429b565b58b77ed73d02e9 100644

--- a/components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc

+++ b/components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc

@@ -22,7 +22,7 @@ namespace syncer {

PersistentPermanentEntity::~PersistentPermanentEntity() {}

// static

-std::unique_ptr<LoopbackServerEntity> PersistentPermanentEntity::Create(

+std::unique_ptr<LoopbackServerEntity> PersistentPermanentEntity::CreateNew(

const ModelType& model_type,

const string& server_tag,

const string& name,