Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 296963002: Show WiFi bootstrapping devices in devices page (Closed)

Created:
6 years, 7 months ago by Noam Samuel
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wifi_impl1_reb
Visibility:
Public.

Description

Show WiFi bootstrapping devices in devices page This is behind the cloud devices flag. Registration is nonworking at the moment. Scan for an display WiFi devices in the devices page. Depends on: https://codereview.chromium.org/294173002/ [build variable for WiFi bootstrapping] https://codereview.chromium.org/226883002/ [WiFi library for cloud devices] https://codereview.chromium.org/288043004/ [bootstrapping device lister] BUG=370071 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275320

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -25 lines) Patch
M chrome/browser/local_discovery/wifi/wifi_manager_nonchromeos.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 1 3 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 1 2 3 5 chunks +84 lines, -19 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Noam Samuel
6 years, 7 months ago (2014-05-21 22:39:51 UTC) #1
Noam Samuel
6 years, 7 months ago (2014-05-21 23:01:13 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 7 months ago (2014-05-22 05:31:35 UTC) #3
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 6 months ago (2014-06-04 20:49:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/296963002/1
6 years, 6 months ago (2014-06-04 20:52:06 UTC) #5
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 6 months ago (2014-06-04 23:44:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/296963002/20001
6 years, 6 months ago (2014-06-04 23:48:30 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 04:19:51 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 04:25:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10815)
6 years, 6 months ago (2014-06-05 04:25:35 UTC) #10
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 6 months ago (2014-06-05 17:43:37 UTC) #11
Vitaly Buka (NO REVIEWS)
On 2014/06/05 04:25:35, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-06-05 17:44:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/296963002/20001
6 years, 6 months ago (2014-06-05 17:46:20 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 19:04:48 UTC) #14
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 6 months ago (2014-06-05 20:10:12 UTC) #15
Noam Samuel
On 2014/06/05 19:04:48, I haz the power (commit-bot) wrote: > FYI, CQ is re-trying this ...
6 years, 6 months ago (2014-06-05 20:10:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/296963002/40001
6 years, 6 months ago (2014-06-05 20:11:50 UTC) #17
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 6 months ago (2014-06-05 22:20:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/296963002/60001
6 years, 6 months ago (2014-06-05 22:20:55 UTC) #19
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 03:31:22 UTC) #20
Message was sent while issue was closed.
Change committed as 275320

Powered by Google App Engine
This is Rietveld 408576698