Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: chrome/browser/feedback/system_logs/system_logs_fetcher.h

Issue 2969573002: Move SystemLogsSource class into new file (Closed)
Patch Set: redundant using Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/feedback/system_logs/system_logs_fetcher.h
diff --git a/chrome/browser/feedback/system_logs/system_logs_fetcher.h b/chrome/browser/feedback/system_logs/system_logs_fetcher.h
index 427b3fcca4320a84e5f074edeb7f79f313166b94..4edb8358e79f94db71a8510af284fc7818b4413a 100644
--- a/chrome/browser/feedback/system_logs/system_logs_fetcher.h
+++ b/chrome/browser/feedback/system_logs/system_logs_fetcher.h
@@ -15,37 +15,16 @@
#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
+#include "chrome/browser/feedback/system_logs/system_logs_source.h"
#include "components/feedback/anonymizer_tool.h"
#include "components/feedback/feedback_common.h"
namespace system_logs {
-using SystemLogsResponse = FeedbackCommon::SystemLogsMap;
-
-// Callback that the data sources use to return data.
-using SysLogsSourceCallback = base::Callback<void(SystemLogsResponse*)>;
-
// Callback that the SystemLogsFetcher uses to return data.
using SysLogsFetcherCallback =
base::Callback<void(std::unique_ptr<SystemLogsResponse>)>;
-// The SystemLogsSource provides an interface for the data sources that
-// the SystemLogsFetcher class uses to fetch logs and other information.
-class SystemLogsSource {
- public:
- // |source_name| provides a descriptive identifier for debugging.
- explicit SystemLogsSource(const std::string& source_name);
- virtual ~SystemLogsSource();
afakhry 2017/07/06 21:43:05 Sorry, I think I missed noticing in the review tha
-
- // Fetches data and passes it by pointer to the callback
- virtual void Fetch(const SysLogsSourceCallback& callback) = 0;
-
- const std::string& source_name() const { return source_name_; }
-
- private:
- std::string source_name_;
-};
-
// The SystemLogsFetcher fetches key-value data from a list of log sources.
//
// EXAMPLE:

Powered by Google App Engine
This is Rietveld 408576698