Chromium Code Reviews| Index: chrome/browser/feedback/system_logs/system_logs_fetcher.h |
| diff --git a/chrome/browser/feedback/system_logs/system_logs_fetcher.h b/chrome/browser/feedback/system_logs/system_logs_fetcher.h |
| index 427b3fcca4320a84e5f074edeb7f79f313166b94..81cf6e156a0710f85195c553911451abdf1dea35 100644 |
| --- a/chrome/browser/feedback/system_logs/system_logs_fetcher.h |
| +++ b/chrome/browser/feedback/system_logs/system_logs_fetcher.h |
| @@ -15,6 +15,7 @@ |
| #include "base/callback.h" |
| #include "base/macros.h" |
| #include "base/memory/weak_ptr.h" |
| +#include "chrome/browser/feedback/system_logs/system_logs_source.h" |
| #include "components/feedback/anonymizer_tool.h" |
| #include "components/feedback/feedback_common.h" |
| @@ -22,30 +23,10 @@ namespace system_logs { |
| using SystemLogsResponse = FeedbackCommon::SystemLogsMap; |
|
afakhry
2017/06/30 23:59:27
Nit: Please remove this from here since you moved
michaelpg
2017/07/05 21:27:39
Done.
|
| -// Callback that the data sources use to return data. |
| -using SysLogsSourceCallback = base::Callback<void(SystemLogsResponse*)>; |
| - |
| // Callback that the SystemLogsFetcher uses to return data. |
| using SysLogsFetcherCallback = |
| base::Callback<void(std::unique_ptr<SystemLogsResponse>)>; |
| -// The SystemLogsSource provides an interface for the data sources that |
| -// the SystemLogsFetcher class uses to fetch logs and other information. |
| -class SystemLogsSource { |
| - public: |
| - // |source_name| provides a descriptive identifier for debugging. |
| - explicit SystemLogsSource(const std::string& source_name); |
| - virtual ~SystemLogsSource(); |
| - |
| - // Fetches data and passes it by pointer to the callback |
| - virtual void Fetch(const SysLogsSourceCallback& callback) = 0; |
| - |
| - const std::string& source_name() const { return source_name_; } |
| - |
| - private: |
| - std::string source_name_; |
| -}; |
| - |
| // The SystemLogsFetcher fetches key-value data from a list of log sources. |
| // |
| // EXAMPLE: |