Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1709)

Unified Diff: appengine/swarming/handlers_bot.py

Issue 2969513002: Add a default Isolate gRPC proxy in config (Closed)
Patch Set: Add a default Isolate gRPC proxy in config Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/swarming/proto/config.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/handlers_bot.py
diff --git a/appengine/swarming/handlers_bot.py b/appengine/swarming/handlers_bot.py
index f961b2cc8aae410dc31999441dfb5f93f72d3b67..656ab8ed2688ca0bb56772d88bf67325d242c5a7 100644
--- a/appengine/swarming/handlers_bot.py
+++ b/appengine/swarming/handlers_bot.py
@@ -93,19 +93,8 @@ def has_missing_keys(minimum_keys, actual_keys, name):
def get_bot_contact_server(request):
Vadim Sh. 2017/06/29 21:56:23 can we remove this function now?
aludwin 2017/06/29 23:38:57 Done.
- """Gets the server contacted by the bot.
-
- Usually, this is the URL of the Swarming server itself, but if the bot
- is communicating to the server by a gRPC intermediary, this will be the
- IP address of the gRPC endpoint. The Native API will have an http or
- https protocol, while gRPC endpoints will have a fake "grpc://" protocol.
- This is to help consumers of this information (mainly the bot code
- generators) distinguish between native and gRPC bots.
- """
- server = request.host_url
- if 'luci-grpc' in request.headers:
- server = 'grpc://%s' % request.headers['luci-grpc']
- return server
+ """Gets the server contacted by the bot."""
+ return request.host_url
class _BotApiHandler(auth.ApiHandler):
« no previous file with comments | « no previous file | appengine/swarming/proto/config.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698