Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

Issue 2969433002: [LayoutNG] Add min/max-{width,height} to instrinics check for abs-pos (Closed)
Patch Set: spelling. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
index 21e540fa8a4e42647e3c3bb956ad660a1e3ff791..99db2c096f4458650b8908c91dc00c5f6383a2a5 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
@@ -101,22 +101,22 @@ RefPtr<NGLayoutResult> NGOutOfFlowLayoutPart::LayoutDescendant(
// relative to the container's padding box.
static_position.offset -= container_border_physical_offset_;
- // The inline and block estimates are in the descendant's writing mode.
- Optional<MinMaxContentSize> inline_estimate;
+ // The block estimate is in the descendant's writing mode.
+ Optional<MinMaxContentSize> min_max_size;
Optional<LayoutUnit> block_estimate;
RefPtr<NGLayoutResult> layout_result = nullptr;
NGWritingMode descendant_writing_mode(
FromPlatformWritingMode(descendant.Style().GetWritingMode()));
- if (AbsoluteNeedsChildInlineSize(descendant.Style())) {
- inline_estimate = descendant.ComputeMinMaxContentSize();
+ if (AbsoluteNeedsChildInlineSize(descendant.Style()) ||
+ NeedMinMaxContentSize(descendant.Style())) {
+ min_max_size = descendant.ComputeMinMaxContentSize();
}
NGAbsolutePhysicalPosition node_position =
ComputePartialAbsoluteWithChildInlineSize(
- *container_space_, descendant.Style(), static_position,
- inline_estimate);
+ *container_space_, descendant.Style(), static_position, min_max_size);
if (AbsoluteNeedsChildBlockSize(descendant.Style())) {
layout_result = GenerateFragment(descendant, block_estimate, node_position);
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698