Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/translate/translate_browser_test_utils.h

Issue 296943002: Simplify and extend commenting in test::ScopedCLDDynamicDataHarness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: msw@ comments redux Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/translate/translate_browser_test_utils.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_TEST_UTILS_H_ 5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_TEST_UTILS_H_
6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_TEST_UTILS_H_ 6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_TEST_UTILS_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 9
10 namespace test { 10 namespace test {
11 11
12 // A utility class that sets up CLD dynamic data upon calling Init() and cleans 12 // A utility class that sets up CLD dynamic data upon calling Init() and cleans
13 // it up when destroyed. 13 // it up when destroyed.
14 // Test data lives under: src/chrome/test/data/cld2_component
14 // 15 //
15 // This class is intended to be instantiated within IN_PROC_BROWSER_TEST_F 16 // This class is intended to be instantiated within IN_PROC_BROWSER_TEST_F
16 // test fixtures; it uses ASSERT macros for correctness, so that tests will 17 // test fixtures; it uses ASSERT macros for correctness, so that tests will
17 // fail gracefully in error conditions. Sample use: 18 // fail gracefully in error conditions. Sample use:
18 // 19 //
19 // #include "chrome/browser/translate/translate_browser_test_utils.h"
20 //
21 // IN_PROC_BROWSER_TEST_F(BrowserTest, PageLanguageDetection) { 20 // IN_PROC_BROWSER_TEST_F(BrowserTest, PageLanguageDetection) {
22 // test::ScopedCLDDynamicDataHarness dynamic_data_scope; 21 // test::ScopedCLDDynamicDataHarness dynamic_data_scope;
23 // ASSERT_NO_FATAL_FAILURE(dynamic_data_scope.Init()); 22 // ASSERT_NO_FATAL_FAILURE(dynamic_data_scope.Init());
24 // // ... your code that depends on language detection goes here 23 // // ... your code that depends on language detection goes here
25 // } 24 // }
26 // 25 //
27 // If you have a lot of tests that need language translation features, you can 26 // If you have a lot of tests that need language translation features, you can
28 // add an instance of the ScopedCLDDynamicDataHarness to your test class' 27 // add an instance of the ScopedCLDDynamicDataHarness to your test class'
29 // private member variables and add the call to Init() into your Setup method. 28 // private member variables and add the call to Init() into SetUpOnMainThread.
29 // Sample use:
30 // 30 //
31 // NB: Test data lives under src/chrome/test/data/cld2_component 31 // class MyTestClass : public InProcessBrowserTest {
32 // public:
33 // virtual void SetUpOnMainThread() OVERRIDE {
34 // dynamic_data_scope.Init();
35 // InProcessBrowserTest::SetUpOnMainThread();
36 // }
37 // private:
38 // test::ScopedCLDDynamicDataHarness dynamic_data_scope;
39 // };
40 //
32 class ScopedCLDDynamicDataHarness { 41 class ScopedCLDDynamicDataHarness {
33 public: 42 public:
34 // Constructs the object, but does nothing. Call Init() to prepare the 43 // Constructs the object, but does nothing. Call Init() to prepare the
35 // harness, and enclose that call in ASSERT_NO_FATAL_FAILURE(...). 44 // harness, and enclose that call in ASSERT_NO_FATAL_FAILURE(...).
36 ScopedCLDDynamicDataHarness(); 45 ScopedCLDDynamicDataHarness();
37 46
38 // Reverses the work done by the constructor: any files and/or directories 47 // Reverses the work done by the constructor: any files and/or directories
39 // that would be created by the constructor are immediately and irrevocably 48 // that would be created by the constructor are immediately and irrevocably
40 // deleted. 49 // deleted.
41 // If dynamic data is not currently available for any reason, this method has 50 // If dynamic data is not currently available for any reason, this method has
42 // no net effect on the runtime. 51 // no net effect on the runtime.
43 ~ScopedCLDDynamicDataHarness(); 52 ~ScopedCLDDynamicDataHarness();
44 53
45 // Call this method, wrapping it in ASSERT_NO_FATAL_FAILURE, to initialize 54 // Call this method, wrapping it in ASSERT_NO_FATAL_FAILURE, to initialize
46 // the harness and trigger test failure of initialization fails. 55 // the harness and trigger test failure of initialization fails.
47 void Init(); 56 void Init();
48 57
49 private: 58 private:
50 void ClearStandaloneDataFileState(); 59 void ClearStandaloneDataFileState();
51 60
52 DISALLOW_COPY_AND_ASSIGN(ScopedCLDDynamicDataHarness); 61 DISALLOW_COPY_AND_ASSIGN(ScopedCLDDynamicDataHarness);
53 }; 62 };
54 63
55 } // namespace test 64 } // namespace test
56 65
57 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_TEST_UTILS_H_ 66 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_TEST_UTILS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/translate/translate_browser_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698