chrome/test/data/webui/print_preview/print_preview_destination_search_test.js - Issue 2969383003: Print Preview: Finish removing global Javascript functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/print_preview/print_preview_destination_search_test.js

Issue 2969383003: Print Preview: Finish removing global Javascript functions. (Closed)

Patch Set: Move listener addition Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('K') | « chrome/test/data/webui/print_preview/plugin_stub.js ('k') | chrome/test/data/webui/print_preview/print_preview_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/print_preview/print_preview_destination_search_test.js

diff --git a/chrome/test/data/webui/print_preview/print_preview_destination_search_test.js b/chrome/test/data/webui/print_preview/print_preview_destination_search_test.js

index e5ea6e424ac0c8542c4a0d93e3c766b031a1ca9b..c2db414fe7518eec2ba41662193837e5a3df78bc 100644

--- a/chrome/test/data/webui/print_preview/print_preview_destination_search_test.js

+++ b/chrome/test/data/webui/print_preview/print_preview_destination_search_test.js

@@ -126,11 +126,6 @@ TEST_F('PrintPreviewDestinationSearchTest', 'Select', function() {

setup(function() {

Mock4JS.clearMocksToVerify();

dpapad 2017/07/07 21:12:41 Can we delete this now? Or is it still used?

rbpotter 2017/07/07 23:58:39 Done. Appears there are no other mocks. Also remo

nativeLayer_ = new print_preview.NativeLayerStub();

- var nativeLayerEventTarget = mock(cr.EventTarget);

- nativeLayer_.setEventTarget(nativeLayerEventTarget.proxy());

- nativeLayerEventTarget.expects(atLeastOnce())

- .addEventListener(ANYTHING, ANYTHING, ANYTHING);

invitationStore_ = new print_preview.InvitationStore();

destinationStore_ = new print_preview.DestinationStore(

nativeLayer_, new print_preview.UserInfo(),