Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/resources/print_preview/previewarea/preview_area.js

Issue 2969383003: Print Preview: Finish removing global Javascript functions. (Closed)
Patch Set: Clean up Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/previewarea/preview_area.js
diff --git a/chrome/browser/resources/print_preview/previewarea/preview_area.js b/chrome/browser/resources/print_preview/previewarea/preview_area.js
index 0e2ff3cddd471ad28cf4df0ad862347328a036a9..79fa954419fde68b785c4c43d434edf0247147e5 100644
--- a/chrome/browser/resources/print_preview/previewarea/preview_area.js
+++ b/chrome/browser/resources/print_preview/previewarea/preview_area.js
@@ -357,6 +357,18 @@ cr.define('print_preview', function() {
this.previewGenerator_,
print_preview.PreviewGenerator.EventType.DOCUMENT_READY,
this.onDocumentReady_.bind(this));
+ this.listenerTracker.add(
+ 'page-count-ready',
+ this.previewGenerator_.onPageCountReady_.bind(
+ this.previewGenerator_));
+ this.listenerTracker.add(
+ 'page-layout-ready',
+ this.previewGenerator_.onPageLayoutReady_.bind(
+ this.previewGenerator_));
+ this.listenerTracker.add(
+ 'page-preview-ready',
+ this.previewGenerator_.onPagePreviewReady_.bind(
+ this.previewGenerator_));
} else {
this.showCustomMessage(loadTimeData.getString('noPlugin'));
}
@@ -365,9 +377,6 @@ cr.define('print_preview', function() {
/** @override */
exitDocument: function() {
print_preview.Component.prototype.exitDocument.call(this);
- if (this.previewGenerator_) {
- this.previewGenerator_.removeEventListeners();
- }
this.overlayEl_ = null;
this.openSystemDialogButton_ = null;
},

Powered by Google App Engine
This is Rietveld 408576698