Print Preview: Finish removing global Javascript functions.

chrome/test/data/webui/print_preview/print_preview_destination_search_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var ROOT_PATH = '../../../../../';
 
 GEN_INCLUDE(
         [ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js']);
 
 /**
@@ skipping 106 matching lines @@
 
       // Select destination.
       if (cr.isChromeOS) {
         destinationSearch.handleConfigureDestination_(dest);
       } else {
         destinationSearch.handleOnDestinationSelect_(dest);
       }
     };
 
     setup(function() {
       Mock4JS.clearMocksToVerify();

[dpapad, 2017/07/07 21:12:41]

Can we delete this now? Or is it still used?

[rbpotter, 2017/07/07 23:58:39]

Done. Appears there are no other mocks.

Also removed teardown().

       nativeLayer_ = new print_preview.NativeLayerStub();
-      var nativeLayerEventTarget = mock(cr.EventTarget);
-      nativeLayer_.setEventTarget(nativeLayerEventTarget.proxy());
-      nativeLayerEventTarget.expects(atLeastOnce())
-          .addEventListener(ANYTHING, ANYTHING, ANYTHING);
-
       invitationStore_ = new print_preview.InvitationStore();
       destinationStore_ = new print_preview.DestinationStore(
           nativeLayer_, new print_preview.UserInfo(),
           new print_preview.AppState());
       userInfo_ = new print_preview.UserInfo();
 
       destinationSearch_ = new print_preview.DestinationSearch(
           destinationStore_, invitationStore_, userInfo_);
       destinationSearch_.decorate($('destination-search'));
     });
 
     teardown(function() {
       Mock4JS.verifyAllMocks();
     });
 
     test('ResolutionFails', function() {
       var destId = "001122DEADBEEF";
       if (cr.isChromeOS) {

[dpapad, 2017/07/07 21:12:41]

Same question here.

[rbpotter, 2017/07/07 23:58:39]

This is still used to distinguish ChromeOS (which triggers a
setupPrinter call) vs non CrOS (triggers a
getLocalDestinationCapabilities call).

         nativeLayer_.setSetupPrinterResponse(true, { printerId: destId,
                                                      success: false,});
       } else {
         nativeLayer_.setLocalDestinationCapabilities({printerId: destId,
                                                       capabilities: getCaps()},
                                                      true);
       }
       requestSetup(destId, destinationSearch_);
       var callback = cr.isChromeOS ? 'setupPrinter' : 'getPrinterCapabilities';
       return nativeLayer_.whenCalled(callback).then(
@@ skipping 66 matching lines @@
       // Simulate a click.
       dest.onActivate_();
 
       // Verify that the destination has been selected.
       assertEquals(printerId, destinationStore_.selectedDestination.id);
     });
   });
 
   mocha.run();
 });