Print Preview: Finish removing global Javascript functions.

chrome/browser/resources/print_preview/data/destination_store.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * A data store that stores destinations and dispatches events when the data
    * store changes.
@@ skipping 159 matching lines @@
         print_preview.DestinationOrigin.LOCAL;
 
     /**
      * Whether to default to the system default printer instead of the most
      * recent destination.
      * @private {boolean}
      */
     this.useSystemDefaultAsDefault_ =
         loadTimeData.getBoolean('useSystemDefaultPrinter');
 
-    this.addEventListeners_();
     this.reset_();
   }
 
   /**
    * Event types dispatched by the data store.
    * @enum {string}
    */
   DestinationStore.EventType = {
     DESTINATION_SEARCH_DONE:
         'print_preview.DestinationStore.DESTINATION_SEARCH_DONE',
@@ skipping 348 matching lines @@
 
     /**
      * @return {boolean} Whether a search for cloud destinations is in progress.
      */
     get isCloudDestinationSearchInProgress() {
       return !!this.cloudPrintInterface_ &&
           this.cloudPrintInterface_.isCloudDestinationSearchInProgress;
     },
 
     /**
+     * Registers the destination store for the WebUI events it responds to and

[dpapad, 2017/07/07 21:12:41]

Nit: Slightly confused by the syntax in this comment. Maybe rephrase/simplify?

[rbpotter, 2017/07/07 23:58:39]

Done.

+     * adds the listeners to |listenerTracker| so that they can be
+     * automatically removed by this tracker later.
+     * @param {!WebUIListenerTracker} listenerTracker The tracker to add the
+     *     listeners to.
+     */
+    addWebUIEventListeners: function(listenerTracker) {
+      listenerTracker.add(
+          'privet-printer-added', this.onPrivetPrinterAdded_.bind(this));
+      listenerTracker.add(
+          'extension-printers-added',
+          this.onExtensionPrintersAdded_.bind(this));
+      listenerTracker.add(
+          'reload-printer-list', this.onDestinationsReload.bind(this));
+    },
+
+    /**
      * Initializes the destination store. Sets the initially selected
      * destination. If any inserted destinations match this ID, that destination
      * will be automatically selected. This method must be called after the
      * print_preview.AppState has been initialized.
      * @param {boolean} isInAppKioskMode Whether the print preview is in App
      *     Kiosk mode.
      * @param {?string} systemDefaultDestinationId ID of the system default
      *     destination.
      * @param {?string} serializedDefaultDestinationSelectionRulesStr Serialized
      *     default destination selection rules.
@@ skipping 613 matching lines @@
     },
 
     /**
      * Dispatches the PROVISIONAL_DESTINATION_RESOLVED event for id
      * |provisionalId| and destination |destination|.
      * @param {string} provisionalId The ID of the destination that was
      *     resolved.
      * @param {?print_preview.Destination} destination Information about the
      *     destination if it was resolved successfully.
      */
-    dispatchProvisionalDestinationResolvedEvent_: function(provisionalId,
-                                                           destination) {
+    dispatchProvisionalDestinationResolvedEvent_: function(
+        provisionalId, destination) {
       var event = new Event(
           DestinationStore.EventType.PROVISIONAL_DESTINATION_RESOLVED);
       event.provisionalId = provisionalId;
       event.destination = destination;
       this.dispatchEvent(event);
     },
 
     /**
      * Inserts {@code destination} to the data store and dispatches a
      * DESTINATIONS_INSERTED event.
@@ skipping 132 matching lines @@
           destination.connectionStatus !=
               print_preview.DestinationConnectionStatus.UNKNOWN) {
         existingDestination.connectionStatus = destination.connectionStatus;
         return true;
       } else {
         return false;
       }
     },
 
     /**
-     * Binds handlers to events.
-     * @private
-     */
-    addEventListeners_: function() {
-      var nativeLayerEventTarget = this.nativeLayer_.getEventTarget();
-      this.tracker_.add(
-          nativeLayerEventTarget,
-          print_preview.NativeLayer.EventType.DESTINATIONS_RELOAD,
-          this.onDestinationsReload_.bind(this));
-    },
-
-    /**
      * Creates a local PDF print destination.
      * @private
      */
     createLocalPdfPrintDestination_: function() {
       // TODO(alekseys): Create PDF printer in the native code and send its
       // capabilities back with other local printers.
       if (this.pdfPrinterEnabled_) {
         this.insertDestination_(new print_preview.Destination(
             print_preview.Destination.GooglePromotedId.SAVE_AS_PDF,
             print_preview.DestinationType.LOCAL,
@@ skipping 184 matching lines @@
      *           name: string,
      *           hasLocalPrinting: boolean,
      *           isUnregistered: boolean,
      *           cloudID: string}} printer Information about the added printer.
      * @private
      */
     onPrivetPrinterAdded_: function(printer) {
       if (printer.serviceName == this.waitForRegisterDestination_ &&
           !printer.isUnregistered) {
         this.waitForRegisterDestination_ = null;
-        this.onDestinationsReload_();
+        this.onDestinationsReload();
       } else {
         this.insertDestinations_(
             print_preview.PrivetDestinationParser.parse(printer));
       }
     },
 
     /**
      * Called when capabilities for a privet printer are set.
      * @param {!print_preview.PrivetPrinterCapabilitiesResponse} printerInfo
      *     Contains the privet printer's description and capabilities.
@@ skipping 47 matching lines @@
           print_preview.DestinationOrigin.EXTENSION, printerId,
           '' /* account */);
       var destination = this.destinationMap_[destinationKey];
       if (!destination)
         return;
       destination.capabilities = capabilities;
       this.updateDestination_(destination);
     },
 
     /**
-     * Called from native layer after the user was requested to sign in, and did
-     * so successfully.
-     * @private
+     * Called from print preview after the user was requested to sign in, and
+     * did so successfully.
      */
-    onDestinationsReload_: function() {
+    onDestinationsReload: function() {
       this.reset_();
       this.autoSelectMatchingDestination_ =
           this.convertPreselectedToDestinationMatch_();
       this.createLocalPdfPrintDestination_();
       this.startLoadAllDestinations();
     },
 
     // TODO(vitalybuka): Remove three next functions replacing Destination.id
     //    and Destination.origin by complex ID.
     /**
@@ skipping 15 matching lines @@
      */
     getKey_: function(destination) {
       return this.getDestinationKey_(
           destination.origin, destination.id, destination.account);
     }
   };
 
   // Export
   return {DestinationStore: DestinationStore};
 });