Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2969373002: fix #29028, understand promoted type parameters (Closed)

Created:
3 years, 5 months ago by Jennifer Messerly
Modified:
3 years, 5 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : better fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -15 lines) Patch
M pkg/dev_compiler/lib/src/compiler/type_utilities.dart View 1 6 chunks +13 lines, -15 lines 0 comments Download
A tests/language_strong/type_variable_promotion_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
3 years, 5 months ago (2017-07-06 02:20:18 UTC) #2
vsm
lgtm
3 years, 5 months ago (2017-07-06 15:34:25 UTC) #3
Jennifer Messerly
3 years, 5 months ago (2017-07-06 20:16:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
79cace0848c57479dca0caa202b71f86e9746e57 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698