Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: content/browser/download/base_file_unittest.cc

Issue 296933016: Avoid trying to delete a non-existent file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/download/base_file.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/download/base_file.h" 5 #include "content/browser/download/base_file.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/files/file.h" 8 #include "base/files/file.h"
9 #include "base/files/scoped_temp_dir.h" 9 #include "base/files/scoped_temp_dir.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 601 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 // be a string-wise match to base_file_->full_path().DirName() even though 612 // be a string-wise match to base_file_->full_path().DirName() even though
613 // they are in the same directory. 613 // they are in the same directory.
614 base::FilePath temp_file; 614 base::FilePath temp_file;
615 ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir_.path(), &temp_file)); 615 ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir_.path(), &temp_file));
616 ASSERT_FALSE(temp_file.empty()); 616 ASSERT_FALSE(temp_file.empty());
617 EXPECT_STREQ(temp_file.DirName().value().c_str(), 617 EXPECT_STREQ(temp_file.DirName().value().c_str(),
618 base_file_->full_path().DirName().value().c_str()); 618 base_file_->full_path().DirName().value().c_str());
619 base_file_->Finish(); 619 base_file_->Finish();
620 } 620 }
621 621
622 TEST_F(BaseFileTest, NoDoubleDeleteAfterCancel) {
623 ASSERT_TRUE(InitializeFile());
624 base::FilePath full_path = base_file_->full_path();
625 ASSERT_FALSE(full_path.empty());
626 ASSERT_TRUE(base::PathExists(full_path));
627
628 base_file_->Cancel();
629 ASSERT_FALSE(base::PathExists(full_path));
630
631 const char kData[] = "hello";
632 const int kDataLength = static_cast<int>(arraysize(kData) - 1);
633 ASSERT_EQ(kDataLength, base::WriteFile(full_path, kData, kDataLength));
634 // The file that we created here should stick around when the BaseFile is
635 // destroyed during TearDown.
636 expect_file_survives_ = true;
637 }
638
622 } // namespace content 639 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/download/base_file.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698