Issue 296923002: Ignored-tests needs no config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296923002: Ignored-tests needs no config. (Closed)

Created:
6 years, 7 months ago by scroggo

Modified:
6 years, 7 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com, fmalita_google_do_not_use, henrik.smiding

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Ignored-tests needs no config. Since we skip based on test, not config, the _8888 and _565 are not necessary and harmful (e.g. the test does not get ignored). NOTREECHECK=True NOTRY=True BUG=skia:2585

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -56 lines)			Patch
	M	expectations/gm/ignored-tests.txt	View		1 chunk	+28 lines, -56 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scroggo

Florin, okay if I submit this? It will "fix" parts of the tree, in that ...

6 years, 7 months ago (2014-05-21 16:15:35 UTC) #1

scroggo

6 years, 7 months ago (2014-05-21 16:42:36 UTC) #3

On 2014/05/21 16:16:00, epoger wrote:
> LGTM_8888

Haha, thx. Abandoning, since the CL it depends on has been reverted. When that
CL (https://codereview.chromium.org/240433002/) is relanded, it should include
this change.

Expand Messages | Collapse Messages