Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5073)

Unified Diff: chrome/browser/banners/app_banner_manager_desktop.cc

Issue 2969163002: Remove AppBannerManager::event_request_id(). (Closed)
Patch Set: Refactor into method Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager_desktop.cc
diff --git a/chrome/browser/banners/app_banner_manager_desktop.cc b/chrome/browser/banners/app_banner_manager_desktop.cc
index 43eb04df232f52e65ac3e6cb8e63dc4d8c70ca7f..e141e10e4c6af50102d0305fa6bb7388e07e09f4 100644
--- a/chrome/browser/banners/app_banner_manager_desktop.cc
+++ b/chrome/browser/banners/app_banner_manager_desktop.cc
@@ -42,7 +42,7 @@ void AppBannerManagerDesktop::DidFinishCreatingBookmarkApp(
if (extension == nullptr) {
Stop();
} else {
- SendBannerAccepted(event_request_id());
+ SendBannerAccepted();
AppBannerSettingsHelper::RecordBannerInstallEvent(
contents, GetAppIdentifier(), AppBannerSettingsHelper::WEB);
@@ -73,8 +73,7 @@ void AppBannerManagerDesktop::ShowBanner() {
// the InfoBarService to show the banner. On desktop, an InfoBar class
// is not required, and the delegate calls the InfoBarService.
infobars::InfoBar* infobar = AppBannerInfoBarDelegateDesktop::Create(
- contents, GetWeakPtr(), bookmark_app_helper_.get(), manifest_,
- event_request_id());
+ contents, GetWeakPtr(), bookmark_app_helper_.get(), manifest_);
if (infobar) {
RecordDidShowBanner("AppBanner.WebApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_WEB_APP_BANNER_CREATED);
« no previous file with comments | « chrome/browser/banners/app_banner_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698