Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2234)

Unified Diff: chrome/browser/banners/app_banner_infobar_delegate_desktop.cc

Issue 2969163002: Remove AppBannerManager::event_request_id(). (Closed)
Patch Set: Refactor into method Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
diff --git a/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc b/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
index 60435211b8c462b867651346d7d5a637e9f84f50..1a8601657ef250ff833ed780892d1cce4aa87be9 100644
--- a/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
+++ b/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
@@ -26,28 +26,24 @@ infobars::InfoBar* AppBannerInfoBarDelegateDesktop::Create(
content::WebContents* web_contents,
base::WeakPtr<AppBannerManager> weak_manager,
extensions::BookmarkAppHelper* bookmark_app_helper,
- const content::Manifest& manifest,
- int event_request_id) {
+ const content::Manifest& manifest) {
InfoBarService* infobar_service =
InfoBarService::FromWebContents(web_contents);
return infobar_service->AddInfoBar(infobar_service->CreateConfirmInfoBar(
std::unique_ptr<ConfirmInfoBarDelegate>(
new AppBannerInfoBarDelegateDesktop(weak_manager, bookmark_app_helper,
- manifest, event_request_id))));
+ manifest))));
}
AppBannerInfoBarDelegateDesktop::AppBannerInfoBarDelegateDesktop(
base::WeakPtr<AppBannerManager> weak_manager,
extensions::BookmarkAppHelper* bookmark_app_helper,
- const content::Manifest& manifest,
- int event_request_id)
+ const content::Manifest& manifest)
: ConfirmInfoBarDelegate(),
weak_manager_(weak_manager),
bookmark_app_helper_(bookmark_app_helper),
manifest_(manifest),
- event_request_id_(event_request_id),
- has_user_interaction_(false) {
-}
+ has_user_interaction_(false) {}
AppBannerInfoBarDelegateDesktop::~AppBannerInfoBarDelegateDesktop() {
if (!has_user_interaction_)
@@ -76,7 +72,7 @@ void AppBannerInfoBarDelegateDesktop::InfoBarDismissed() {
InfoBarService::WebContentsFromInfoBar(infobar());
if (web_contents) {
if (weak_manager_)
- weak_manager_->SendBannerDismissed(event_request_id_);
+ weak_manager_->SendBannerDismissed();
AppBannerSettingsHelper::RecordBannerDismissEvent(
web_contents, manifest_.start_url.spec(), AppBannerSettingsHelper::WEB);
« no previous file with comments | « chrome/browser/banners/app_banner_infobar_delegate_desktop.h ('k') | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698