Fixes redirects to external apps when navigating from PWA.

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappTabDelegate.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 package org.chromium.chrome.browser.webapps;
 
+import android.content.Intent;
+import android.content.pm.ResolveInfo;
 import android.net.Uri;
 import android.support.customtabs.CustomTabsIntent;
 
+import org.chromium.base.Log;
+import org.chromium.chrome.browser.IntentHandler;
+import org.chromium.chrome.browser.customtabs.CustomTabIntentDataProvider;
+import org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tab.TabIdManager;
 import org.chromium.chrome.browser.tabmodel.AsyncTabParamsManager;
 import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
 import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParams;
 import org.chromium.chrome.browser.tabmodel.document.TabDelegate;
 
+import java.net.URISyntaxException;
+import java.util.List;
+
 /**
  * Asynchronously creates Tabs for navigation originating from an installed PWA.
  *
  * This is the same as the parent class with exception of opening a Custom Tab for
  * {@code _blank} links and {@code window.open(url)} calls instead of creating a new tab in Chrome.
  */
 public class WebappTabDelegate extends TabDelegate {
+    private static final String TAG = "WebappTabDelegate";
+
     private final WebappActivity mActivity;
+    private ExternalNavigationDelegateImpl mExternalNavigationDelegate; // Initialized lazily
 
     public WebappTabDelegate(WebappActivity activity, boolean incognito) {
         super(incognito);
         this.mActivity = activity;
     }
 
     @Override
     public void createNewTab(AsyncTabCreationParams asyncParams, TabLaunchType type, int parentId) {
+        String url = asyncParams.getLoadUrlParams().getUrl();
+        if (maybeStartExternalActivity(url)) {
+            return;
+        }
+
         int assignedTabId = TabIdManager.getInstance().generateValidId(Tab.INVALID_TAB_ID);
         AsyncTabParamsManager.add(assignedTabId, asyncParams);
 
-        CustomTabsIntent customTabIntent =
-                new CustomTabsIntent.Builder().setShowTitle(true).build();
+        Intent intent = new CustomTabsIntent.Builder().setShowTitle(true).build().intent;
+        intent.setData(Uri.parse(url));
+        intent.putExtra(CustomTabIntentDataProvider.EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER, true);
+        intent.putExtra(CustomTabIntentDataProvider.EXTRA_IS_OPENED_BY_CHROME, true);
+        addAsyncTabExtras(asyncParams, parentId, false /* isChromeUI */, assignedTabId, intent);
 
-        customTabIntent.intent.setPackage(mActivity.getPackageName());
-        addAsyncTabExtras(asyncParams, parentId, true, assignedTabId, customTabIntent.intent);
-        customTabIntent.launchUrl(mActivity, Uri.parse(asyncParams.getLoadUrlParams().getUrl()));
+        IntentHandler.startActivityForTrustedIntent(intent);
+    }
+
+    private boolean maybeStartExternalActivity(String url) {
+        Intent intent;
+        try {
+            intent = Intent.parseUri(url, Intent.URI_INTENT_SCHEME);
+        } catch (URISyntaxException ex) {
+            Log.w(TAG, "Bad URI %s", url, ex);
+            return false;
+        }
+
+        if (shouldStartExternalActivity(intent)) {
+            mActivity.startActivity(intent);

[Yusuf, 2017/07/19 03:33:37]

I think dependence on ExternalNavigationDelegate here is hurting us because it
makes us create and cache stuff unnecessarily. It would be good to not cache the
Activity here.

isSpecializedHandler is pretty generic code through PackageManager. And we do go
through the same queryActivities/resolve logic in other places. It might be even
be possible to make getSpecializedHandlersWithFilter static there. Can we try
that or just copying an independent impl here and use
ContextUtils.getApplicationContext to launch the intent and not depend on any
params?

[piotrs, 2017/07/19 04:06:25]

I found isPackageSpecializedHandler, which is what I needed and is static.
Cleaned up, PTAL :)

+            return true;
+        }
+
+        return false;
+    }
+
+    private boolean shouldStartExternalActivity(Intent intent) {
+        if (intent.getPackage() != null) return true;

[Yusuf, 2017/07/19 03:33:37]

is this needed? Explicit intents should be covered well with the
isSpecializedHandlerAvailable below.

[piotrs, 2017/07/19 04:06:25]

Ack, removed.

+
+        if (mExternalNavigationDelegate == null) {
+            mExternalNavigationDelegate =
+                    new ExternalNavigationDelegateImpl(mActivity.getActivityTab());
+        }
+
+        List<ResolveInfo> infos = mExternalNavigationDelegate.queryIntentActivities(intent);
+        return mExternalNavigationDelegate.isSpecializedHandlerAvailable(infos);
     }
 }