Implement type variables on old style function-typed formal parameters.

Implement type variables on old style function-typed formal parameters.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/5999f45148fe51cb2e20389ee38b351427868521

[ahe, 2017-07-04 13:51:47]

Patchset #1 (id:1) has been deleted

[ahe, 2017-07-04 13:53:25]

ahe@google.com changed reviewers:
+ danrubel@google.com, johnniwinther@google.com

[Johnni Winther, 2017-07-05 10:46:00]

lgtm

https://codereview.chromium.org/2969053002/diff/20001/pkg/analyzer/lib/src/fa...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/2969053002/diff/20001/pkg/analyzer/lib/src/fa...
pkg/analyzer/lib/src/fasta/ast_builder.dart:847: if
(typeOrFunctionTypedParameter is FunctionTypedFormalParameter) {
Add comment that this is created as an temp object in
endFunctionTypedFormalParameter

https://codereview.chromium.org/2969053002/diff/20001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/node_listener.dart (right):

https://codereview.chromium.org/2969053002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/node_listener.dart:786: null));
Yikes ;)

[ahe, 2017-07-05 11:52:12]

Thank you, Johnni!

https://codereview.chromium.org/2969053002/diff/20001/pkg/analyzer/lib/src/fa...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/2969053002/diff/20001/pkg/analyzer/lib/src/fa...
pkg/analyzer/lib/src/fasta/ast_builder.dart:847: if
(typeOrFunctionTypedParameter is FunctionTypedFormalParameter) {
On 2017/07/05 10:46:00, Johnni Winther wrote:
> Add comment that this is created as an temp object in
> endFunctionTypedFormalParameter

Done.

https://codereview.chromium.org/2969053002/diff/20001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/node_listener.dart (right):

https://codereview.chromium.org/2969053002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/node_listener.dart:786: null));
On 2017/07/05 10:46:00, Johnni Winther wrote:
> Yikes ;)

Acknowledged.

[ahe, 2017-07-05 12:54:27]

Description was changed from

==========
Implement type variables on old style function-typed formal parameters.
==========

to

==========
Implement type variables on old style function-typed formal parameters.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5999f45148fe51cb2e20389ee38b351427868521
==========

[ahe, 2017-07-05 12:54:29]

Committed patchset #2 (id:40001) manually as
5999f45148fe51cb2e20389ee38b351427868521 (presubmit successful).