Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2969013002: Support creating elements from IR nodes in JsKernelToElementMap (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support creating elements from IR nodes in JsKernelToElementMap R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f081f8b47dc3620d1c977d54ff9d76baea024bb1

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -83 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 1 chunk +24 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 7 chunks +102 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 23 chunks +198 lines, -48 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kelements.dart View 6 chunks +9 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/js_model/model_test.dart View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-04 08:38:14 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2969013002/diff/1/pkg/compiler/lib/src/common_elements.dart File pkg/compiler/lib/src/common_elements.dart (right): https://codereview.chromium.org/2969013002/diff/1/pkg/compiler/lib/src/common_elements.dart#newcode949 pkg/compiler/lib/src/common_elements.dart:949: member.name == 'checkInt' && nit: let's move this ...
3 years, 5 months ago (2017-07-05 20:13:37 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as f081f8b47dc3620d1c977d54ff9d76baea024bb1 (presubmit successful).
3 years, 5 months ago (2017-07-06 13:30:14 UTC) #5
Johnni Winther
3 years, 5 months ago (2017-07-06 13:30:40 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2969013002/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common_elements.dart (right):

https://codereview.chromium.org/2969013002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common_elements.dart:949: member.name == 'checkInt' &&
On 2017/07/05 20:13:37, Siggi Cherem (dart-lang) wrote:
> nit: let's move this one last, since I expect it's the most expensive check
> (same below)

Done.

https://codereview.chromium.org/2969013002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2969013002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:517: /// creating K-model
elements.
On 2017/07/05 20:13:37, Siggi Cherem (dart-lang) wrote:
> update doc:
>  - this one is basically implementing in terms of the create* APIs
>  - move the K-specific part of the doc to the class below?

Done.

Powered by Google App Engine
This is Rietveld 408576698