Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 296893009: Remove frameID hack for history. (Closed)

Created:
6 years, 7 months ago by dcheng
Modified:
6 years, 7 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews
Visibility:
Public.

Description

Remove frameID hack for history. This isn't needed anymore since history is maintained by the embedder. BUG=none R=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M Source/core/frame/Frame.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/frame/Frame.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
6 years, 7 months ago (2014-05-22 23:50:44 UTC) #1
Nate Chapin
LGTM, thanks.
6 years, 7 months ago (2014-05-23 17:04:51 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 7 months ago (2014-05-23 17:22:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/296893009/1
6 years, 7 months ago (2014-05-23 17:23:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 18:44:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 20:02:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/8967)
6 years, 7 months ago (2014-05-23 20:02:34 UTC) #7
dcheng
6 years, 7 months ago (2014-05-23 21:18:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r174712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698