[SyncFS] Make DriveBackendSyncTest run in multi-threaded env.

[SyncFS] Make DriveBackendSyncTest run in multi-threaded environment.


BUG=347425
TEST=./unit_tests --gtest_filter="DriveBackendSyncTest.*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273150

[peria, 2014-05-26 08:52:06]

PTL.

[nhiroki, 2014-05-26 09:56:00]

Looks good with very trivial nits.

https://codereview.chromium.org/296893002/diff/190001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc
(right):

https://codereview.chromium.org/296893002/diff/190001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:46:
SyncStatusCode status_in) {
In syncfs, we haven't used "_in" suffix for input arguments. I don't have a
strong opinion about this, but generally it seems to be a good practice to go
along with existing code. Wdyt?

https://codereview.chromium.org/296893002/diff/190001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:79:

Can you move this to line 83 or just call
content::BrowserThread::GetBlockingPool()->GetSequenced...?

https://codereview.chromium.org/296893002/diff/190001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:198:
}
You are already surrounded with if-block.

https://codereview.chromium.org/296893002/diff/190001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:532:
scoped_refptr<base::SequencedTaskRunner> worker_task_runner_;
Can you move this after |file_task_runner_| to sort them in setup-order.

[peria, 2014-05-27 02:40:12]

https://codereview.chromium.org/296893002/diff/190001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc
(right):

https://codereview.chromium.org/296893002/diff/190001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:46:
SyncStatusCode status_in) {
On 2014/05/26 09:56:00, nhiroki wrote:
> In syncfs, we haven't used "_in" suffix for input arguments. I don't have a
> strong opinion about this, but generally it seems to be a good practice to go
> along with existing code. Wdyt?

Done.
Going along with current code is better, I think.

https://codereview.chromium.org/296893002/diff/190001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:79:

On 2014/05/26 09:56:00, nhiroki wrote:
> Can you move this to line 83 or just call
> content::BrowserThread::GetBlockingPool()->GetSequenced...?

Done.

https://codereview.chromium.org/296893002/diff/190001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:198:
}
On 2014/05/26 09:56:00, nhiroki wrote:
> You are already surrounded with if-block.

Done.

https://codereview.chromium.org/296893002/diff/190001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:532:
scoped_refptr<base::SequencedTaskRunner> worker_task_runner_;
On 2014/05/26 09:56:00, nhiroki wrote:
> Can you move this after |file_task_runner_| to sort them in setup-order.

Done.
I changed the order of setting them up.
I and Tsuiki-san have an agreement to sort those task runners in
UI->worker->file order.

[nhiroki, 2014-05-27 03:29:09]

lgtm

[tzik, 2014-05-27 07:10:55]

LGTM

[peria, 2014-05-27 07:25:06]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-05-27 07:25:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/296893002/200001

[peria, 2014-05-27 07:34:45]

The CQ bit was unchecked by peria@chromium.org

[peria, 2014-05-27 08:08:14]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-05-27 08:08:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/296893002/220001

[commit-bot: I haz the power, 2014-05-27 11:25:50]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-27 11:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 11:33:59]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[peria, 2014-05-27 11:39:57]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-05-27 11:40:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/296893002/220001

[commit-bot: I haz the power, 2014-05-27 12:57:16]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-27 13:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 13:05:00]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[peria, 2014-05-27 15:32:03]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-05-27 15:32:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/296893002/220001

[commit-bot: I haz the power, 2014-05-27 16:00:04]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-27 16:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 16:26:25]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[peria, 2014-05-28 02:03:59]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-05-28 02:04:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/296893002/240001

[commit-bot: I haz the power, 2014-05-28 05:26:33]

Change committed as 273150