Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: pkg/analysis_server/test/services/correction/assist_test.dart

Issue 2968883002: Fix a test so that it passes (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/correction/assist_test.dart
diff --git a/pkg/analysis_server/test/services/correction/assist_test.dart b/pkg/analysis_server/test/services/correction/assist_test.dart
index 7af0f29c3ce676923a9e0670bc8d388cddb23d5f..bdcdda72b56b5a656c9d1550ea0dbf3d1d8ad8f3 100644
--- a/pkg/analysis_server/test/services/correction/assist_test.dart
+++ b/pkg/analysis_server/test/services/correction/assist_test.dart
@@ -166,7 +166,6 @@ class A<T> {
await assertNoAssistAt('var item', DartAssistKind.ADD_TYPE_ANNOTATION);
}
- @failingTest
test_addTypeAnnotation_BAD_privateType_list() async {
// This is now failing because we're suggesting "List" rather than nothing.
// Is it really better to produce nothing?
@@ -184,7 +183,15 @@ main() {
var v = getValues();
}
''');
- await assertNoAssistAt('var ', DartAssistKind.ADD_TYPE_ANNOTATION);
+ await assertHasAssistAt(
+ 'var ',
+ DartAssistKind.ADD_TYPE_ANNOTATION,
+ '''
+import 'my_lib.dart';
+main() {
+ List v = getValues();
+}
+''');
}
test_addTypeAnnotation_BAD_privateType_variable() async {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698