Avoid Stack Overflows during VirtualTree expansion

runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart

Index: runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart b/runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..249dfd26914749cc45a49708b1b141ecfc73ed37
--- /dev/null
+++ b/runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart
@@ -0,0 +1,100 @@
+// Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file

[rmacnak, 2017/07/06 00:10:20]

2017

[cbernaschina, 2017/07/06 00:33:46]

Done.

+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:html';
+import 'package:unittest/unittest.dart';
+import 'package:observatory/src/elements/containers/virtual_collection.dart';
+import 'package:observatory/src/elements/containers/virtual_tree.dart';
+
+main() {
+  VirtualTreeElement.tag.ensureRegistration();
+
+  final cTag = VirtualCollectionElement.tag.name;
+
+  var container;
+  setUp(() {
+    container = document.body.getElementsByClassName('test_container').first;
+  });
+  group('instantiation', () {
+    test('default', () {
+      final e = new VirtualTreeElement((_) {}, (_1, _2, _3) {}, (_) {});
+      expect(e, isNotNull, reason: 'element correctly created');
+      expect(e.items, isNotNull, reason: 'items not null');
+      expect(e.items, isEmpty, reason: 'no items');
+    });
+    test('items: []', () {
+      final items = ["1", 2, {}];
+      final e =
+          new VirtualTreeElement((_) {}, (_1, _2, _3) {}, (_) {}, items: items);
+      expect(e, isNotNull, reason: 'element correctly created');
+      expect(e.items, isNot(same(items)), reason: 'avoid side effect');
+      expect(e.items, equals(items), reason: 'same items');
+    });
+  });
+  test('elements created after attachment', () async {
+    final create = (toggle) => new DivElement()..classes = ['test_item'];
+    final update = (HtmlElement el, item, depth) {
+      el.text = item.toString();
+    };
+    final children = (item) => [];
+    final items = ["1", 2, {}];
+    final e = new VirtualTreeElement(create, update, children);
+    container.append(e);
+    await e.onRendered.first;
+    expect(e.children.length, isNonZero, reason: 'has elements');
+    expect(e.querySelectorAll(cTag).length, same(1));
+    e.remove();
+    await e.onRendered.first;
+    expect(e.children.length, isZero, reason: 'is empty');
+  });
+  test('expand single child', () async {
+    const max_depth = 100000;
+    final create = (toggle) => new DivElement()..classes = ['test_item'];
+    final update = (HtmlElement el, item, depth) {
+      el.text = item.toString();
+    };
+    final children = (item) => item >= max_depth ? [] : [item + 1];

[rmacnak, 2017/07/06 00:10:20]

Presumably you wanted to have multiple children here to prevent the whole tree
from being expanded? Otherwise this is the same as 'expand whole tree' below.

[cbernaschina, 2017/07/06 00:33:46]

Done.

+    final items = [0];
+    final e = new VirtualTreeElement(create, update, children, items: items);
+    container.append(e);
+    await e.onRendered.first;
+    expect(e.children.length, isNonZero, reason: 'has elements');
+    final VirtualCollectionElement collection = e.querySelectorAll(cTag).first;
+    expect(collection.items.length, equals(1), reason: 'begin');
+    e.expand(0, autoExpandSingleChildNodes: true);
+    await e.onRendered.first;
+    expect(collection.items.length, equals(max_depth + 1), reason: 'expanded');
+    e.collapse(0, autoCollapseSingleChildNodes: true);
+    await e.onRendered.first;
+    expect(collection.items.length, equals(1), reason: 'collapsed');
+    e.remove();
+    await e.onRendered.first;
+    expect(e.children.length, isZero, reason: 'is empty');
+  });
+
+  test('expand whole tree', () async {
+    const max_depth = 100000;
+    final create = (toggle) => new DivElement()..classes = ['test_item'];
+    final update = (HtmlElement el, item, depth) {
+      el.text = item.toString();
+    };
+    final children = (item) => item >= max_depth ? [] : [item + 1];
+    final items = [0];
+    final e = new VirtualTreeElement(create, update, children, items: items);
+    container.append(e);
+    await e.onRendered.first;
+    expect(e.children.length, isNonZero, reason: 'has elements');
+    final VirtualCollectionElement collection = e.querySelectorAll(cTag).first;
+    expect(collection.items.length, equals(1), reason: 'begin');
+    e.expand(0, autoExpandWholeTree: true);
+    await e.onRendered.first;
+    expect(collection.items.length, equals(max_depth + 1), reason: 'expanded');
+    e.collapse(0, autoCollapseWholeTree: true);
+    await e.onRendered.first;
+    expect(collection.items.length, equals(1), reason: 'collapsed');
+    e.remove();
+    await e.onRendered.first;
+    expect(e.children.length, isZero, reason: 'is empty');
+  });
+}