Avoid Stack Overflows during VirtualTree expansion

Avoid Stack Overflows during VirtualTree expansion

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/6be07a30bce87a884d0cf3cd904d28ee5ad2bc18

[cbernaschina, 2017-06-30 23:17:39]

cbernaschina@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-07-06 00:10:20]

https://codereview.chromium.org/2968813002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/containers/virtual_tree.dart (right):

https://codereview.chromium.org/2968813002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/containers/virtual_tree.dart:93: Queue toDo
= new Queue();
Maybe add a note here that the tree is potentially very deep so no one looks at
this later and switches it back to simple recursion.

Consider "pendingNodes" instead of "toDo"

https://codereview.chromium.org/2968813002/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart
(right):

https://codereview.chromium.org/2968813002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart:1: //
Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
2017

https://codereview.chromium.org/2968813002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart:57:
final children = (item) => item >= max_depth ? [] : [item + 1];
Presumably you wanted to have multiple children here to prevent the whole tree
from being expanded? Otherwise this is the same as 'expand whole tree' below.

[cbernaschina, 2017-07-06 00:33:46]

https://codereview.chromium.org/2968813002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/containers/virtual_tree.dart (right):

https://codereview.chromium.org/2968813002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/containers/virtual_tree.dart:93: Queue toDo
= new Queue();
On 2017/07/06 00:10:20, rmacnak wrote:
> Maybe add a note here that the tree is potentially very deep so no one looks
at
> this later and switches it back to simple recursion.
> 
> Consider "pendingNodes" instead of "toDo"

Done.

https://codereview.chromium.org/2968813002/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart
(right):

https://codereview.chromium.org/2968813002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart:1: //
Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
On 2017/07/06 00:10:20, rmacnak wrote:
> 2017

Done.

https://codereview.chromium.org/2968813002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/observatory_ui/virtual_tree/element_test.dart:57:
final children = (item) => item >= max_depth ? [] : [item + 1];
On 2017/07/06 00:10:20, rmacnak wrote:
> Presumably you wanted to have multiple children here to prevent the whole tree
> from being expanded? Otherwise this is the same as 'expand whole tree' below.

Done.

[rmacnak, 2017-07-06 00:45:41]

lgtm

[cbernaschina, 2017-07-06 00:47:08]

Description was changed from

==========
Avoid Stack Overflows during VirtualTree expansion
==========

to

==========
Avoid Stack Overflows during VirtualTree expansion

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6be07a30bce87a884d0cf3cd904d28ee5ad2bc18
==========

[cbernaschina, 2017-07-06 00:47:09]

Committed patchset #3 (id:40001) manually as
6be07a30bce87a884d0cf3cd904d28ee5ad2bc18 (presubmit successful).