Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: pkg/compiler/lib/src/inferrer/closure_tracer.dart

Issue 2968743002: Use .callMethod instead of LocalFunctionElement as key in inference (Closed)
Patch Set: Updated cf. comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder.dart ('k') | pkg/compiler/lib/src/inferrer/inferrer_engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/inferrer/closure_tracer.dart
diff --git a/pkg/compiler/lib/src/inferrer/closure_tracer.dart b/pkg/compiler/lib/src/inferrer/closure_tracer.dart
index 0c7eed2d732dca35ef8010c7eb1c6d0319467542..3901f8c46976f064e4876509c1f6b833d389fc9d 100644
--- a/pkg/compiler/lib/src/inferrer/closure_tracer.dart
+++ b/pkg/compiler/lib/src/inferrer/closure_tracer.dart
@@ -15,7 +15,7 @@ import 'node_tracer.dart';
import 'type_graph_nodes.dart';
class ClosureTracerVisitor extends TracerVisitor {
- final Iterable<FunctionElement> tracedElements;
+ final Iterable<MethodElement> tracedElements;
final List<CallSiteTypeInformation> _callsToAnalyze =
new List<CallSiteTypeInformation>();
@@ -29,7 +29,7 @@ class ClosureTracerVisitor extends TracerVisitor {
analyze();
if (!continueAnalyzing) return;
_callsToAnalyze.forEach(_analyzeCall);
- for (FunctionElement e in tracedElements) {
+ for (MethodElement e in tracedElements) {
e.functionSignature.forEachParameter((Element parameter) {
ElementTypeInformation info =
inferrer.types.getInferredTypeOfParameter(parameter);
@@ -52,7 +52,7 @@ class ClosureTracerVisitor extends TracerVisitor {
void _analyzeCall(CallSiteTypeInformation info) {
Selector selector = info.selector;
TypeMask mask = info.mask;
- tracedElements.forEach((FunctionElement functionElement) {
+ tracedElements.forEach((MethodElement functionElement) {
if (!selector.callStructure
.signatureApplies(functionElement.parameterStructure)) {
return;
@@ -130,7 +130,8 @@ class ClosureTracerVisitor extends TracerVisitor {
}
class StaticTearOffClosureTracerVisitor extends ClosureTracerVisitor {
- StaticTearOffClosureTracerVisitor(tracedElement, tracedType, inferrer)
+ StaticTearOffClosureTracerVisitor(
+ MethodElement tracedElement, tracedType, inferrer)
: super([tracedElement], tracedType, inferrer);
@override
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder.dart ('k') | pkg/compiler/lib/src/inferrer/inferrer_engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698