Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: chrome/browser/ui/views/harmony/chrome_layout_provider.h

Issue 2968713003: Harmonize the find in page dialog. (Closed)
Patch Set: Added distance metrics for toast button/label/text. Using these in the find bar. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
6 #define CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_ 6 #define CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 19 matching lines...) Expand all
30 DISTANCE_RELATED_LABEL_HORIZONTAL_LIST, 30 DISTANCE_RELATED_LABEL_HORIZONTAL_LIST,
31 // Horizontal indent of a subsection relative to related items above, e.g. 31 // Horizontal indent of a subsection relative to related items above, e.g.
32 // checkboxes below explanatory text/headings. 32 // checkboxes below explanatory text/headings.
33 DISTANCE_SUBSECTION_HORIZONTAL_INDENT, 33 DISTANCE_SUBSECTION_HORIZONTAL_INDENT,
34 // Horizontal spacing between controls that are logically unrelated. 34 // Horizontal spacing between controls that are logically unrelated.
35 DISTANCE_UNRELATED_CONTROL_HORIZONTAL, 35 DISTANCE_UNRELATED_CONTROL_HORIZONTAL,
36 // Larger horizontal spacing between unrelated controls. 36 // Larger horizontal spacing between unrelated controls.
37 DISTANCE_UNRELATED_CONTROL_HORIZONTAL_LARGE, 37 DISTANCE_UNRELATED_CONTROL_HORIZONTAL_LARGE,
38 // Larger vertical spacing between unrelated controls. 38 // Larger vertical spacing between unrelated controls.
39 DISTANCE_UNRELATED_CONTROL_VERTICAL_LARGE, 39 DISTANCE_UNRELATED_CONTROL_VERTICAL_LARGE,
40 // Vertical margin for buttons in a toast.
41 DISTANCE_TOAST_BUTTON_VERTICAL,
Peter Kasting 2017/07/13 04:52:47 Combine BUTTON and TEXT (which I think really mean
ananta 2017/07/13 05:22:10 Done.
42 // Vertical spacing for text in a toast.
43 DISTANCE_TOAST_TEXT_VERTICAL,
44 // Vertical spacing for labels in a toast.
45 DISTANCE_TOAST_LABEL_VERTICAL,
40 }; 46 };
41 47
42 class ChromeLayoutProvider : public views::LayoutProvider { 48 class ChromeLayoutProvider : public views::LayoutProvider {
43 public: 49 public:
44 ChromeLayoutProvider() {} 50 ChromeLayoutProvider() {}
45 ~ChromeLayoutProvider() override {} 51 ~ChromeLayoutProvider() override {}
46 52
47 static ChromeLayoutProvider* Get(); 53 static ChromeLayoutProvider* Get();
48 static std::unique_ptr<views::LayoutProvider> CreateLayoutProvider(); 54 static std::unique_ptr<views::LayoutProvider> CreateLayoutProvider();
49 55
(...skipping 23 matching lines...) Expand all
73 // types, e.g. by adding a new LayoutDistance value that means what you need. 79 // types, e.g. by adding a new LayoutDistance value that means what you need.
74 // 80 //
75 // TODO(pkasting): Fix callers and remove this. 81 // TODO(pkasting): Fix callers and remove this.
76 virtual bool IsHarmonyMode() const; 82 virtual bool IsHarmonyMode() const;
77 83
78 private: 84 private:
79 DISALLOW_COPY_AND_ASSIGN(ChromeLayoutProvider); 85 DISALLOW_COPY_AND_ASSIGN(ChromeLayoutProvider);
80 }; 86 };
81 87
82 #endif // CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_ 88 #endif // CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698