Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Issue 2968603002: [gen_snapshot] Write only one target in the depfile to appease Ninja. (Closed)

Created:
3 years, 5 months ago by rmacnak
Modified:
3 years, 5 months ago
Reviewers:
goderbauer, zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[gen_snapshot] Write only one target in the depfile to appease Ninja. Since the other targets are generated by the same action, it is enough that Ninja sees only one output as dirty. Add missing dependencies for core-jit snapshots. Fuchsia issue TO-365 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/f445c318184b30b3db997ac27f357bcb5d45670a

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -40 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 3 chunks +75 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
3 years, 5 months ago (2017-06-29 23:01:36 UTC) #3
zra
lgtm
3 years, 5 months ago (2017-06-29 23:16:11 UTC) #5
rmacnak
3 years, 5 months ago (2017-06-29 23:54:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f445c318184b30b3db997ac27f357bcb5d45670a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698