Check the return value of base::StringToInt() in

net/proxy/proxy_config_service_linux_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_config_service_linux.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 11 matching lines @@
 #include "base/strings/stringprintf.h"
 #include "base/synchronization/lock.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/thread.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "net/proxy/proxy_config.h"
 #include "net/proxy/proxy_config_service_common_unittest.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
+// TODO(eroman): Convert these to parameterized tests using TEST_P().
+
 namespace net {
 namespace {
 
 // Set of values for all environment variables that we might
 // query. NULL represents an unset variable.
 struct EnvVarValues {
   // The strange capitalization is so that the field matches the
   // environment variable name exactly.
   const char* DESKTOP_SESSION;
   const char* HOME;
@@ skipping 1108 matching lines @@
           // Input.
           "[Proxy Settings]\nProxyType=0\n",
           {},  // env_values
 
           // Expected result.
           ProxyConfigService::CONFIG_VALID,
           false,   // auto_detect
           GURL(),  // pac_url
           ProxyRulesExpectation::Empty(),
       },
+      {
+          TEST_DESC("No proxying (negative value)"),

[mmenke, 2017/06/29 22:21:20]

Maybe a test in each group where the ProxyType is not a number.  "ProxyType=AB-"
and "ReversedException=noitpecxE" are my suggestions.  :)

[eroman, 2017/06/29 22:33:58]

Done.

+
+          // Input.
+          "[Proxy Settings]\nProxyType=-3\n",
+          {},  // env_values
+
+          // Expected result.
+          ProxyConfigService::CONFIG_VALID,
+          false,   // auto_detect
+          GURL(),  // pac_url
+          ProxyRulesExpectation::Empty(),
+      },
 
       {
           TEST_DESC("Auto detect"),
 
           // Input.
           "[Proxy Settings]\nProxyType=3\n",
           {},  // env_values
 
           // Expected result.
           ProxyConfigService::CONFIG_VALID,
@@ skipping 136 matching lines @@
           false,   // auto_detect
           GURL(),  // pac_url
           ProxyRulesExpectation::PerScheme(
               "www.google.com:80",        // http
               "",                         // https
               "",                         // ftp
               "*.google.com,*.kde.org"),  // bypass rules
       },
 
       {
-          TEST_DESC("Correctly parse bypass list with ReversedException"),
+          TEST_DESC("Correctly parse bypass list with ReversedException=true"),
 
           // Input.
           "[Proxy Settings]\nProxyType=1\nhttpProxy=www.google.com\n"
           "NoProxyFor=.google.com\nReversedException=true\n",
           {},  // env_values
 
           // Expected result.
           ProxyConfigService::CONFIG_VALID,
           false,   // auto_detect
           GURL(),  // pac_url
           ProxyRulesExpectation::PerSchemeWithBypassReversed(
               "www.google.com:80",  // http
               "",                   // https
               "",                   // ftp
               "*.google.com"),      // bypass rules
       },
 
       {
+          TEST_DESC("Correctly parse bypass list with ReversedException=1"),
+
+          // Input.
+          "[Proxy Settings]\nProxyType=1\nhttpProxy=www.google.com\n"
+          "NoProxyFor=.google.com\nReversedException=1\n",
+          {},  // env_values
+
+          // Expected result.
+          ProxyConfigService::CONFIG_VALID,
+          false,   // auto_detect
+          GURL(),  // pac_url
+          ProxyRulesExpectation::PerSchemeWithBypassReversed(
+              "www.google.com:80",  // http
+              "",                   // https
+              "",                   // ftp
+              "*.google.com"),      // bypass rules
+      },
+
+      {
+          TEST_DESC("Correctly parse bypass list with ReversedException=false"),

[eroman, 2017/06/29 21:11:18]

This is weird -- it tries parsing "false" as a number, and fails, so treats it
as 0 (false). Hmm.

+
+          // Input.
+          "[Proxy Settings]\nProxyType=1\nhttpProxy=www.google.com\n"
+          "NoProxyFor=.google.com\nReversedException=false\n",
+          {},  // env_values
+
+          // Expected result.
+          ProxyConfigService::CONFIG_VALID,
+          false,                                                 // auto_detect
+          GURL(),                                                // pac_url
+          ProxyRulesExpectation::PerScheme("www.google.com:80",  // http
+                                           "",                   // https
+                                           "",                   // ftp
+                                           "*.google.com"),      // bypass rules
+      },
+
+      {
+          TEST_DESC("Correctly parse bypass list with "
+                    "ReversedException=18446744073709551617"),

[eroman, 2017/06/29 21:11:18]

Previously this would be interpreted as true (because overflow causes non-zero
result) whereas now it is false.

Which is equally strange, but not something I think matters one way or another.

+
+          // Input.
+          "[Proxy Settings]\nProxyType=1\nhttpProxy=www.google.com\n"
+          "NoProxyFor=.google.com\nReversedException=18446744073709551617\n",
+          {},  // env_values
+
+          // Expected result.
+          ProxyConfigService::CONFIG_VALID,
+          false,                                                 // auto_detect
+          GURL(),                                                // pac_url
+          ProxyRulesExpectation::PerScheme("www.google.com:80",  // http
+                                           "",                   // https
+                                           "",                   // ftp
+                                           "*.google.com"),      // bypass rules
+      },
+
+      {
           TEST_DESC("socks"),
 
           // Input.
           "[Proxy Settings]\nProxyType=1\nsocksProxy=socks.com 888\n",
           {},  // env_values
 
           // Expected result.
           ProxyConfigService::CONFIG_VALID,
           false,   // auto_detect
           GURL(),  // pac_url
@@ skipping 456 matching lines @@
 
   //-----------------------------------------------------
 
   // TODO(eroman): Add a test where kioslaverc is deleted next. Currently this
   //               doesn't trigger any notifications, but it probably should.
 }
 
 }  // namespace
 
 }  // namespace net