Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 296853010: Sync the alert() IDL with the spec (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Sync the alert() IDL with the spec http://html5.org/r/8638 https://www.w3.org/Bugs/Public/show_bug.cgi?id=25686 This does not change the behavior of alert() or alert(undefined), it is a pre-emptive change so that treating undefined as a missing optional argument (per WebIDL) does not change the behavior. BUG=335871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/core/frame/DOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 7 months ago (2014-05-23 10:53:05 UTC) #1
Nils Barth (inactive)
LGTM. For those following along at home: this change looks funny (why not just alert(optional ...
6 years, 7 months ago (2014-05-27 01:30:17 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-05-27 07:44:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/296853010/1
6 years, 7 months ago (2014-05-27 07:44:41 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 07:57:29 UTC) #5
Message was sent while issue was closed.
Change committed as 174845

Powered by Google App Engine
This is Rietveld 408576698