Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2968473002: Remove incremental: logger, validator, options. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -546 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 7 chunks +0 lines, -62 lines 0 comments Download
M pkg/analysis_server/lib/src/status/diagnostics.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 4 chunks +0 lines, -32 lines 0 comments Download
D pkg/analyzer/lib/src/generated/incremental_logger.dart View 1 chunk +0 lines, -204 lines 0 comments Download
D pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart View 1 chunk +0 lines, -207 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-06-29 17:24:31 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-06-29 18:13:49 UTC) #2
scheglov
3 years, 5 months ago (2017-06-29 18:51:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
077b6b687d90ad6089245ade868649010b6d3298 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698