Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: pkg/compiler/lib/src/js_model/elements.dart

Issue 2968383002: Add ConstructorBodyEntity (Closed)
Patch Set: Skip non-live constructor bodies Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_model/closure.dart ('k') | pkg/compiler/lib/src/kernel/element_map.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_model/elements.dart
diff --git a/pkg/compiler/lib/src/js_model/elements.dart b/pkg/compiler/lib/src/js_model/elements.dart
index f156f056acb6eb3017e72f63100c48d33c2ce431..30244c06d019de9266f6598c5c4acf1970b08180 100644
--- a/pkg/compiler/lib/src/js_model/elements.dart
+++ b/pkg/compiler/lib/src/js_model/elements.dart
@@ -66,6 +66,7 @@ abstract class JsToFrontendMapBase implements JsToFrontendMap {
TypeVariableEntity toFrontendTypeVariable(TypeVariableEntity typeVariable);
}
+// TODO(johnniwinther): Merge this with [JsKernelToElementMap].
class JsElementCreatorMixin {
IndexedLibrary createLibrary(
int libraryIndex, String name, Uri canonicalUri) {
@@ -109,6 +110,11 @@ class JsElementCreatorMixin {
isFromEnvironmentConstructor: isFromEnvironmentConstructor);
}
+ ConstructorBodyEntity createConstructorBody(
+ int memberIndex, ConstructorEntity constructor) {
+ return new JConstructorBody(memberIndex, constructor);
+ }
+
IndexedFunction createGetter(int memberIndex, LibraryEntity library,
ClassEntity enclosingClass, Name name, AsyncMarker asyncMarker,
{bool isStatic, bool isExternal, bool isAbstract}) {
@@ -419,6 +425,26 @@ class JFactoryConstructor extends JConstructor {
bool get isGenerativeConstructor => false;
}
+class JConstructorBody extends JFunction implements ConstructorBodyEntity {
+ final ConstructorEntity constructor;
+
+ JConstructorBody(int memberIndex, this.constructor)
+ : super(
+ memberIndex,
+ constructor.library,
+ constructor.enclosingClass,
+ constructor.memberName,
+ constructor.parameterStructure,
+ AsyncMarker.SYNC,
+ isStatic: false,
+ isExternal: false);
+
+ @override
+ bool get isFunction => true;
+
+ String get _kind => 'constructor_body';
+}
+
class JMethod extends JFunction {
final bool isAbstract;
« no previous file with comments | « pkg/compiler/lib/src/js_model/closure.dart ('k') | pkg/compiler/lib/src/kernel/element_map.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698