Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2968383002: Add ConstructorBodyEntity (Closed)
Patch Set: Skip non-live constructor bodies Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
index a8e04792ad9068c8e88799fd94d7b7a1a38ecb65..9b4955b8d101c35410746bfc41ef873b4f69562c 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
@@ -17,7 +17,6 @@ import '../../deferred_load.dart' show DeferredLoadTask, OutputUnit;
import '../../elements/elements.dart'
show
ClassElement,
- ConstructorBodyElement,
Elements,
FieldElement,
FunctionSignature,
@@ -759,11 +758,10 @@ class ProgramBuilder {
// only interested in direct members.
if (!onlyForRti && !_elementEnvironment.isMixinApplication(cls)) {
_elementEnvironment.forEachClassMember(cls, visitMember);
- if (cls is ClassElement) {
- // TODO(redemption): Support constructor bodies for entities.
- cls.forEachConstructorBody((ConstructorBodyElement constructorBody) =>
- visitMember(cls, constructorBody));
- }
+ _elementEnvironment.forEachConstructorBody(
+ cls,
+ (ConstructorBodyEntity constructorBody) =>
+ visitMember(cls, constructorBody));
}
bool isInterceptedClass = _interceptorData.isInterceptedClass(cls);
List<Field> instanceFields = onlyForRti
@@ -932,7 +930,7 @@ class ProgramBuilder {
if (canTearOff) {
assert(element is! ConstructorEntity, failedAt(element));
- assert(element is! ConstructorBodyElement, failedAt(element));
+ assert(element is! ConstructorBodyEntity, failedAt(element));
}
js.Name callName = null;
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart ('k') | pkg/compiler/lib/src/js_model/closure.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698