Add ConstructorBodyEntity

pkg/compiler/lib/src/js_model/closure.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../closure.dart';
 import '../common/tasks.dart';
 import '../elements/entities.dart';
 import '../kernel/element_map.dart';
@@ skipping 127 matching lines @@
 
   @override
   // TODO(efortuna): Eventually closureScopeMap[node] should always be non-null,
   // and we should just test that with an assert.
   LoopClosureScope getLoopClosureScope(ir.Node loopNode) =>
       _closureScopeMap[loopNode] ?? const LoopClosureScope();
 
   @override
   // TODO(efortuna): Eventually closureRepresentationMap[node] should always be
   // non-null, and we should just test that with an assert.
-  ClosureRepresentationInfo getClosureRepresentationInfo(Entity entity) =>
-      _closureRepresentationMap[entity] ?? const ClosureRepresentationInfo();
+  ClosureRepresentationInfo getClosureRepresentationInfo(Entity entity) {
+    if (entity is ConstructorBodyEntity) {
+      ConstructorBodyEntity constructorBody = entity;
+      entity = constructorBody.constructor;

[Siggi Cherem (dart-lang), 2017/07/07 20:00:25]

it might be nice to do this at the call site though.

Don't we know at the callsite whether we are in a ctor body and should be using
the ctor as a key?

Also - this depends on what we decide about the K constructorbodyentities: if we
say that they are created later and they don't exit by the time we do closure
conversion, then  it feels odd that the closure task has to be aware of them at
all.

[Johnni Winther, 2017/07/10 14:11:33]

Long-term constructor body should have there own associated
ClosureRepresentationInfo. Adding a TODO.

+    }
+    return _closureRepresentationMap[entity] ??
+        const ClosureRepresentationInfo();
+  }
 }
 
 class KernelScopeInfo extends ScopeInfo {
   final Set<Local> localsUsedInTryOrSync;
   final Local thisLocal;
   final Set<Local> boxedVariables;
 
   /// The set of variables that were defined in another scope, but are used in
   /// this scope.
   Set<ir.VariableDeclaration> freeVariables = new Set<ir.VariableDeclaration>();
@@ skipping 83 matching lines @@
   // TODO(efortuna): Implement.
   bool isVariableBoxed(Local variable) => false;
 
   // TODO(efortuna): Implement.
   // Why is this closure not actually a closure? Well, to properly call
   // ourselves a closure, we need to register the new closure class with the
   // ClosedWorldRefiner, which currently only takes elements. The change to
   // that (and the subsequent adjustment here) will follow soon.
   bool get isClosure => false;
 }