Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2968283002: Fixed synchronization problem in FF and Safari for virtual-tree test (Closed)

Created:
3 years, 5 months ago by cbernaschina
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed synchronization problem in FF and Safari for virtual-tree test Closes #30087 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/15970f2a7ee793c1b60c6e44a53014aced216e08

Patch Set 1 #

Patch Set 2 : Clear the RenderScheduler wait list after notification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M runtime/observatory/lib/src/elements/containers/virtual_tree.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart View 1 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/observatory_ui.status View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/virtual_tree/element_test.html View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
cbernaschina
Tested on FF/Chrome/Dartium, but unable to test it on Safari, I'm on a linux workstation
3 years, 5 months ago (2017-07-06 20:23:03 UTC) #1
cbernaschina
3 years, 5 months ago (2017-07-06 22:43:54 UTC) #2
cbernaschina
3 years, 5 months ago (2017-07-07 17:13:27 UTC) #5
rmacnak
lgtm
3 years, 5 months ago (2017-07-07 20:33:33 UTC) #6
cbernaschina
3 years, 5 months ago (2017-07-07 20:39:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
15970f2a7ee793c1b60c6e44a53014aced216e08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698