Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issue 2968233002: Add code to run more tests from test_all (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -23 lines) Patch
M pkg/analysis_server/test/edit/test_all.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A pkg/analysis_server/test/services/completion/postfix/test_all.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/services/completion/statement/test_all.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 1 chunk +6 lines, -5 lines 0 comments Download
A pkg/analysis_server/test/services/linter/test_all.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/test_all.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 5 chunks +3 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/test_all.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 3 chunks +5 lines, -3 lines 1 comment Download
M pkg/analyzer/test/src/task/strong/test_all.dart View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Brian Wilkerson
3 years, 5 months ago (2017-07-06 18:37:23 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2968233002/diff/1/pkg/analyzer/test/src/summary/test_all.dart File pkg/analyzer/test/src/summary/test_all.dart (right): https://codereview.chromium.org/2968233002/diff/1/pkg/analyzer/test/src/summary/test_all.dart#newcode30 pkg/analyzer/test/src/summary/test_all.dart:30: // marked as failing to make it easier ...
3 years, 5 months ago (2017-07-06 18:40:56 UTC) #3
Brian Wilkerson
Paul: Should we just remove those tests?
3 years, 5 months ago (2017-07-06 18:43:43 UTC) #5
Paul Berry
On 2017/07/06 18:43:43, Brian Wilkerson wrote: > Paul: Should we just remove those tests? Konstantin ...
3 years, 5 months ago (2017-07-06 19:11:19 UTC) #6
Brian Wilkerson
3 years, 5 months ago (2017-07-06 19:24:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4549862881f1ab123eb58bb0236db1cf2f20ac4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698