Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2968213002: update pub to get --build-delay arg and remove require.js loading timeouts (Closed)

Created:
3 years, 5 months ago by jakemac
Modified:
3 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

update pub to get --build-delay arg and remove require.js loading timeouts BUG= R=nweiz@google.com Committed: https://github.com/dart-lang/sdk/commit/c4ea80a74c132bcf6a99740ef0c4266a2bdaa06e

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review update #

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M CHANGELOG.md View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jakemac
I also removed the section about bug fixes that was duplicated in the 1.24.1 release ...
3 years, 5 months ago (2017-07-06 17:07:28 UTC) #2
nweiz
lgtm https://codereview.chromium.org/2968213002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2968213002/diff/1/CHANGELOG.md#newcode54 CHANGELOG.md:54: * This is configurable with the `--build-delay` argument ...
3 years, 5 months ago (2017-07-06 20:51:26 UTC) #3
jakemac
https://codereview.chromium.org/2968213002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2968213002/diff/1/CHANGELOG.md#newcode54 CHANGELOG.md:54: * This is configurable with the `--build-delay` argument which ...
3 years, 5 months ago (2017-07-06 21:14:08 UTC) #4
jakemac
3 years, 5 months ago (2017-07-06 21:16:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c4ea80a74c132bcf6a99740ef0c4266a2bdaa06e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698