Toolbar: Report offline state through icon and verbose text.

components/toolbar/toolbar_model_impl.cc

Index: components/toolbar/toolbar_model_impl.cc
diff --git a/components/toolbar/toolbar_model_impl.cc b/components/toolbar/toolbar_model_impl.cc
index c24a388aad0e259a105c68c6030818e74ca0f57a..8d3b2ac97be072df9cfa64428d7ae1c9ec6420da 100644
--- a/components/toolbar/toolbar_model_impl.cc
+++ b/components/toolbar/toolbar_model_impl.cc
@@ -79,6 +79,9 @@ const gfx::VectorIcon& ToolbarModelImpl::GetVectorIcon() const {
   if (icon_override)
     return *icon_override;
 
+  if (IsOfflinePage())
+    return toolbar::kOfflinePinIcon;

[Peter Kasting, 2017/07/07 01:21:55]

There should probably be unittest additions for these changes.

[cjgrant, 2017/07/07 15:08:00]

I had checked for cases where we test the icons/strings returned, but didn't see
anything (which makes sense as ToolbarModel is a source of truth (why test that
the truth is true? :) )).

I'll add a test to our VR URL bar texture to verify the icons and chips.  Would
you add a desktop equivalent?  If so, which module gets it?

[cjgrant, 2017/07/07 17:27:44]

Actually, I partially coded the test, and realized I'm actually only testing our
VR ToolbarHelper class, not ToolbarModel.  It sounds like you'd like a new
ToolbarModel unit test, I think.

+
   switch (GetSecurityLevel(false)) {
     case security_state::NONE:
     case security_state::HTTP_SHOW_WARNING:
@@ -121,6 +124,9 @@ base::string16 ToolbarModelImpl::GetEVCertName() const {
 }
 
 base::string16 ToolbarModelImpl::GetSecureVerboseText() const {
+  if (IsOfflinePage())
+    return l10n_util::GetStringUTF16(IDS_OFFLINE_VERBOSE_STATE);
+
   switch (GetSecurityLevel(false)) {
     case security_state::HTTP_SHOW_WARNING:
       return l10n_util::GetStringUTF16(IDS_NOT_SECURE_VERBOSE_STATE);