components/omnibox_strings.grdp - Issue 2968143003: Toolbar: Report offline state through icon and verbose text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox_strings.grdp

Issue 2968143003: Toolbar: Report offline state through icon and verbose text. (Closed)

Patch Set: . Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/vr_shell/textures/url_bar_texture.cc ('K') | « chrome/browser/android/vr_shell/textures/url_bar_texture.cc ('k') | components/toolbar/BUILD.gn » ('j') | components/toolbar/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox_strings.grdp

diff --git a/components/omnibox_strings.grdp b/components/omnibox_strings.grdp

index 0c341ee424f8843914ecb8bfc0d29da1027f0773..954cf3f197ce3cb25e1becfa4dc198969383659c 100644

--- a/components/omnibox_strings.grdp

+++ b/components/omnibox_strings.grdp

@@ -32,6 +32,9 @@

Dangerous

</message>

+ <message name="IDS_OFFLINE_VERBOSE_STATE" desc="Text for the Offline Omnibox Verbose srate. Displayed when the current page is loaded from a previously-downloaded cache.">

cjgrant 2017/07/06 19:19:16 Do the states here have to be documented somewhere

fgorski 2017/07/06 20:01:34 typo: s/srate/state/

cjgrant 2017/07/06 20:13:00 Oops! Nice catch, sorry.

cjgrant 2017/07/06 20:53:58 Done.

+ Offline

+ </message>

Search or type URL