content/browser/service_worker/service_worker_url_request_job_unittest.cc - Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options (Closed)

Patch Set: address more comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_storage_unittest.cc ('k') | content/browser/service_worker/service_worker_version_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

index 01daa9dd9ecb46d7eb606ff4234dbff2713f80b2..fa2287545029008b8f648248e48863b5a0116a85 100644

--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

@@ -178,7 +178,8 @@ class ServiceWorkerURLRequestJobTest

helper_ = std::move(helper);

registration_ = new ServiceWorkerRegistration(

- GURL("https://example.com/"), 1L, helper_->context()->AsWeakPtr());

+ ServiceWorkerRegistrationOptions(GURL("https://example.com/")), 1L,

+ helper_->context()->AsWeakPtr());

version_ = new ServiceWorkerVersion(

registration_.get(), GURL("https://example.com/service_worker.js"), 1L,

helper_->context()->AsWeakPtr());