content/browser/service_worker/service_worker_registration.cc - Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options (Closed)

Patch Set: address more comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_registration.cc

diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc

index 42a8ae4e052f8c76b1c2a4354385286137c4d35e..ca1ca39d3026a55f450fc80e751bb1141a222892 100644

--- a/content/browser/service_worker/service_worker_registration.cc

+++ b/content/browser/service_worker/service_worker_registration.cc

@@ -38,10 +38,10 @@ ServiceWorkerVersionInfo GetVersionInfo(ServiceWorkerVersion* version) {

} // namespace

ServiceWorkerRegistration::ServiceWorkerRegistration(

- const GURL& pattern,

+ const ServiceWorkerRegistrationOptions& options,

int64_t registration_id,

base::WeakPtr<ServiceWorkerContextCore> context)

- : pattern_(pattern),

+ : pattern_(options.scope),

registration_id_(registration_id),

is_deleted_(false),

is_uninstalling_(false),