Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: content/browser/service_worker/service_worker_context_wrapper.cc

Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options (Closed)
Patch Set: address more comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_wrapper.cc
diff --git a/content/browser/service_worker/service_worker_context_wrapper.cc b/content/browser/service_worker/service_worker_context_wrapper.cc
index eddab03b89532ee169e5ca3d30d2099f5705a2dc..ac5d75abc23ca8b75e96c30cb05f6a75675b5079 100644
--- a/content/browser/service_worker/service_worker_context_wrapper.cc
+++ b/content/browser/service_worker/service_worker_context_wrapper.cc
@@ -273,9 +273,10 @@ void ServiceWorkerContextWrapper::RegisterServiceWorker(
base::Bind(continuation, false));
return;
}
+ ServiceWorkerRegistrationOptions options(net::SimplifyUrlForRequest(pattern));
context()->RegisterServiceWorker(
- net::SimplifyUrlForRequest(pattern),
- net::SimplifyUrlForRequest(script_url), NULL /* provider_host */,
+ net::SimplifyUrlForRequest(script_url), options,
+ nullptr /* provider_host */,
base::Bind(&FinishRegistrationOnIO, continuation));
}

Powered by Google App Engine
This is Rietveld 408576698